Brett SmithBug #2936
Pipeline instance component display: for a finished pi (and probably for one in progress with multiple components), the job progress bar is not red if the job has failed.
100%
Subtasks
Associated revisions
2936: fix job progress bars
Add edge case settings for when a crunch job could not be started, or
when no tasks were ever created.
Calculate percent_total_tasks as a float, to ensure that it will be
nonzero even if there are more than 100 tasks altogether. Calculate
percentages of individual task progress with .ceil to ensure that there
will be at least 1% shown for each nonzero task status.
Refs #2936
Merge branch '2936-job-progress-bar'
Closes #2936.
History
#1
Updated by Radhika Chippada almost 7 years ago
Updated by Radhika Chippada It appears that tasks_summary sent to _job_progress.html.erb is not populated with the correct values.
#2
Updated by Ward Vandewege almost 7 years ago
Updated by - Subject changed from Pipeline instance component display: for a finished pi (and probably for one in progress with multiple components), the job progress bar is not red if the job has failed. to Pipeline instance component display: for a finished pi (and probably for one in progress with multiple components), the job progress bar is not red if the job has failed.
- Story points set to 0.5
#3
Updated by Tim Pierce over 6 years ago
Updated by Tim Pierce - Assigned To set to Tim Pierce
#4
Updated by Tim Pierce over 6 years ago
- Status changed from New to Resolved
- % Done changed from 0 to 100
Applied in changeset arvados|commit:4b8a53c9cfc81a942f985f1799dbc6e27deb3bc2.
#5
Updated by Tim Pierce over 6 years ago
- Status changed from Resolved to In Progress
#6
Updated by Brett Smith over 6 years ago
Updated by Brett Smith #3034 specifies: "job progress bars reflect at least one task. If a job has no tasks at all (done, failed, finished, or todo) that should be considered a failed job, so render a progress bar as though one task ran and failed."
The code doesn't do that. Instead, it renders a completely empty progress bar (unless the whole job is marked as failed). I believe the implemented behavior is more correct (otherwise we'd render a failure bar for any Job which hasn't even started yet), so I'm fine with that. However, I wanted to flag the discrepancy for attention. If you had the same thought I did, or this implementation is consistent with follow-up discussion not in the ticket, then ee69f70 looks good to merge to me. Thanks.
#7
Updated by Tim Pierce over 6 years ago
Brett Smith wrote:
#3034 specifies: "job progress bars reflect at least one task. If a job has no tasks at all (done, failed, finished, or todo) that should be considered a failed job, so render a progress bar as though one task ran and failed."
The code doesn't do that. Instead, it renders a completely empty progress bar (unless the whole job is marked as failed). I believe the implemented behavior is more correct (otherwise we'd render a failure bar for any Job which hasn't even started yet), so I'm fine with that. However, I wanted to flag the discrepancy for attention. If you had the same thought I did, or this implementation is consistent with follow-up discussion not in the ticket, then ee69f70 looks good to merge to me. Thanks.
You're correct, thanks for pointing it out. After submitting the review task, discussion about the desired behavior convinced me that we want an empty progress bar in this case. Going ahead and merging.
#8
Updated by Tim Pierce over 6 years ago
- Status changed from In Progress to Resolved
Applied in changeset arvados|commit:7e88a950d4fdbc2790e6164aa7d947b491419f21.
2936: improve progress bar for failed jobs
Ensure that:
tasks at all (done, failed, finished, or todo) that should be
considered a failed job, so render a progress bar as though one task
ran and failed.
task. If a job is marked as failed but has no failed tasks, then
pretend there was one failed task so at least some red will appear in
the progress bar.
Fixes #2936.