Bug #2936

Pipeline instance component display: for a finished pi (and probably for one in progress with multiple components), the job progress bar is not red if the job has failed.

Added by Radhika Chippada over 6 years ago. Updated over 6 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Tim Pierce
Category:
-
Start date:
06/17/2014
Due date:
% Done:

100%

Estimated time:
(Total: 0.50 h)
Story points:
0.5

Subtasks

Task #3035: Fix progress bar rendering in _job_progress.html.erbResolvedTim Pierce

Task #3034: Review 2936-job-progress-barResolvedTim Pierce

Associated revisions

Revision 4b8a53c9 (diff)
Added by Tim Pierce over 6 years ago

2936: improve progress bar for failed jobs

Ensure that:

  • All job progress bars reflect at least one task. If a job has no
    tasks at all (done, failed, finished, or todo) that should be
    considered a failed job, so render a progress bar as though one task
    ran and failed.
  • A failed job (j[:success] == false) always shows at least one failed
    task. If a job is marked as failed but has no failed tasks, then
    pretend there was one failed task so at least some red will appear in
    the progress bar.

Fixes #2936.

Revision ee69f703 (diff)
Added by Tim Pierce over 6 years ago

2936: fix job progress bars

Add edge case settings for when a crunch job could not be started, or
when no tasks were ever created.

Calculate percent_total_tasks as a float, to ensure that it will be
nonzero even if there are more than 100 tasks altogether. Calculate
percentages of individual task progress with .ceil to ensure that there
will be at least 1% shown for each nonzero task status.

Refs #2936

Revision 7e88a950
Added by Tim Pierce over 6 years ago

Merge branch '2936-job-progress-bar'

Closes #2936.

History

#1 Updated by Radhika Chippada over 6 years ago

It appears that tasks_summary sent to _job_progress.html.erb is not populated with the correct values.

#2 Updated by Ward Vandewege over 6 years ago

  • Subject changed from Pipeline instance component display: for a finished pi (and probably for one in progress with multiple components), the job progress bar is not red if the job has failed. to Pipeline instance component display: for a finished pi (and probably for one in progress with multiple components), the job progress bar is not red if the job has failed.
  • Story points set to 0.5

#3 Updated by Tim Pierce over 6 years ago

  • Assigned To set to Tim Pierce

#4 Updated by Tim Pierce over 6 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100

Applied in changeset arvados|commit:4b8a53c9cfc81a942f985f1799dbc6e27deb3bc2.

#5 Updated by Tim Pierce over 6 years ago

  • Status changed from Resolved to In Progress

#6 Updated by Brett Smith over 6 years ago

#3034 specifies: "job progress bars reflect at least one task. If a job has no tasks at all (done, failed, finished, or todo) that should be considered a failed job, so render a progress bar as though one task ran and failed."

The code doesn't do that. Instead, it renders a completely empty progress bar (unless the whole job is marked as failed). I believe the implemented behavior is more correct (otherwise we'd render a failure bar for any Job which hasn't even started yet), so I'm fine with that. However, I wanted to flag the discrepancy for attention. If you had the same thought I did, or this implementation is consistent with follow-up discussion not in the ticket, then ee69f70 looks good to merge to me. Thanks.

#7 Updated by Tim Pierce over 6 years ago

Brett Smith wrote:

#3034 specifies: "job progress bars reflect at least one task. If a job has no tasks at all (done, failed, finished, or todo) that should be considered a failed job, so render a progress bar as though one task ran and failed."

The code doesn't do that. Instead, it renders a completely empty progress bar (unless the whole job is marked as failed). I believe the implemented behavior is more correct (otherwise we'd render a failure bar for any Job which hasn't even started yet), so I'm fine with that. However, I wanted to flag the discrepancy for attention. If you had the same thought I did, or this implementation is consistent with follow-up discussion not in the ticket, then ee69f70 looks good to merge to me. Thanks.

You're correct, thanks for pointing it out. After submitting the review task, discussion about the desired behavior convinced me that we want an empty progress bar in this case. Going ahead and merging.

#8 Updated by Tim Pierce over 6 years ago

  • Status changed from In Progress to Resolved

Applied in changeset arvados|commit:7e88a950d4fdbc2790e6164aa7d947b491419f21.

Also available in: Atom PDF