Bug #2936
closed
Pipeline instance component display: for a finished pi (and probably for one in progress with multiple components), the job progress bar is not red if the job has failed.
Updated by Radhika Chippada over 10 years ago
It appears that tasks_summary sent to _job_progress.html.erb is not populated with the correct values.
Updated by Ward Vandewege over 10 years ago
- Subject changed from Pipeline instance component display: for a finished pi (and probably for one in progress with multiple components), the job progress bar is not red if the job has failed. to Pipeline instance component display: for a finished pi (and probably for one in progress with multiple components), the job progress bar is not red if the job has failed.
- Story points set to 0.5
Updated by Tim Pierce over 10 years ago
- Status changed from New to Resolved
- % Done changed from 0 to 100
Applied in changeset arvados|commit:4b8a53c9cfc81a942f985f1799dbc6e27deb3bc2.
Updated by Tim Pierce over 10 years ago
- Status changed from Resolved to In Progress
Updated by Brett Smith over 10 years ago
#3034 specifies: "job progress bars reflect at least one task. If a job has no tasks at all (done, failed, finished, or todo) that should be considered a failed job, so render a progress bar as though one task ran and failed."
The code doesn't do that. Instead, it renders a completely empty progress bar (unless the whole job is marked as failed). I believe the implemented behavior is more correct (otherwise we'd render a failure bar for any Job which hasn't even started yet), so I'm fine with that. However, I wanted to flag the discrepancy for attention. If you had the same thought I did, or this implementation is consistent with follow-up discussion not in the ticket, then ee69f70 looks good to merge to me. Thanks.
Updated by Tim Pierce over 10 years ago
Brett Smith wrote:
#3034 specifies: "job progress bars reflect at least one task. If a job has no tasks at all (done, failed, finished, or todo) that should be considered a failed job, so render a progress bar as though one task ran and failed."
The code doesn't do that. Instead, it renders a completely empty progress bar (unless the whole job is marked as failed). I believe the implemented behavior is more correct (otherwise we'd render a failure bar for any Job which hasn't even started yet), so I'm fine with that. However, I wanted to flag the discrepancy for attention. If you had the same thought I did, or this implementation is consistent with follow-up discussion not in the ticket, then ee69f70 looks good to merge to me. Thanks.
You're correct, thanks for pointing it out. After submitting the review task, discussion about the desired behavior convinced me that we want an empty progress bar in this case. Going ahead and merging.
Updated by Tim Pierce over 10 years ago
- Status changed from In Progress to Resolved
Applied in changeset arvados|commit:7e88a950d4fdbc2790e6164aa7d947b491419f21.