Arvados

• I'm getting a number of Workbench test failures. I'm concerned that calling super from various index methods could have unintended side effects, since ApplicationController#index always reassigns to the objects array. Some of these other controllers build data structures that accompany or parallel @objects, and things could get out of whack if ApplicationController#index munges that. Would it make sense to make the rendering at the end of @ApplicationController#index its own method, and then call that from the end of these other index methods?
• ERB output in JavaScript (e.g., ajaxRefreshTabPane) needs to be run through escape_javascript.
• Please update the comments in event_log.js to match your changes.
• Please remove the debug puts from ApplicationController.

• Made the suggested change, added #render_index which is used where appropriate instead of #super
• Workbench tests should pass
• Added missing user uuid to session
• Tracks up-to-date state of each panel, only reloads it if it believes it needs to be reloaded.

Very nice, thanks. My only question now is about the changes related to ApplicationController#current_user. I remember some discussion about caching user information in the session, but since thread_with_api_token usually calls User.current, it seems like this usually won't save us a round-trip with the API server. Nothing else in the branch seems to be using the data saved in the session, either. What is this getting us?

Brett Smith wrote:

Very nice, thanks. My only question now is about the changes related to ApplicationController#current_user. I remember some discussion about caching user information in the session, but since thread_with_api_token usually calls User.current, it seems like this usually won't save us a round-trip with the API server. Nothing else in the branch seems to be using the data saved in the session, either. What is this getting us?

Covered in-person. I wasn't paying enough attention to realize that User.current only gets called if params[:api_token]. Looks good to me; please merge.