Bug #3099

ajax-loader.gif gives 406 Not Acceptable in production mode.

Added by Tom Clegg almost 5 years ago. Updated almost 5 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Target version:
Start date:
06/27/2014
Due date:
% Done:

100%

Estimated time:
(Total: 0.50 h)
Story points:
1.0

Subtasks

Task #3105: Review 3099-spinner-assetsResolvedTom Clegg

Task #3104: Fix asset pipeline usageResolvedTom Clegg

Associated revisions

Revision f1298638
Added by Tom Clegg almost 5 years ago

Merge branch '3099-spinner-assets' closes #3099

History

#1 Updated by Tom Clegg almost 5 years ago

https://workbench.4xphq.arvadosapi.com/assets/ajax-loader.gif → 406

Started GET "/assets/ajax-loader.gif" for 198.91.224.175 at 2014-06-26 19:30:09 +0000
Processing by LinksController#render_not_found as GIF
  Parameters: {"a"=>"assets/ajax-loader"}
#<ActionController::RoutingError: Path not found>
#<ActionController::UnknownFormat: ActionController::UnknownFormat>

Meanwhile, the previously existing (smaller) loading gif continues to work:

https://workbench.4xphq.arvadosapi.com/assets/loading.gif → OK

#2 Updated by Tom Clegg almost 5 years ago

  • Status changed from New to In Progress
  • Assigned To set to Tom Clegg

#3 Updated by Tom Clegg almost 5 years ago

Places affected:
  • Bottom of infinite scroll, e.g., bottom of "show project" page in a project that has many items
  • Preview panel in "choose collection" modal, e.g., show project → add data... → click a collection
    • This one worked in development mode but was broken in production mode, e.g., right now on staging site
    • Spinner is now centered in the preview panel, instead of top left
  • "Log" pane on "show job" page

#4 Updated by Tom Clegg almost 5 years ago

Radhika Chippada wrote (on #3105):

- infinite_scroll.js: you do not seem to be using infinite-scroller-spinner anymore. If so, you may want to delete it at line 17

Indeed, missed that one. Deleted.

- spinner-h-center and spinner-v-center are not used in some of the spinner div elements, probably intentional.

Right, whether v-center makes sense depends on the context. There are still some cases that aren't perfect yet (like the collection list in the chooser when it first comes up or you update the search box) but I didn't want to put "infinite" time into css quite yet. ;)

That said, when viewing a project with many items, the spinner appears at the bottom of the page towards the left, instead of horizontal center. I think it should appear in the middle horizontally. It might also be desirable that it appears in the vertical center of the page.

Horizontal: indeed, I had punted on this but when I looked into why it was neither left-aligned nor centered, I realized that the markup was actually wrong (tbody>div) so I fixed it (tbody>tr>td>div) and now it gets centered properly.

Vertical: Not totally sure what the best place is (v-center of space between last table row and bottom of visible portion of screen?) and it seems a bit too finicky. (Maybe on the next round, with some input from UI people?)

#5 Updated by Radhika Chippada almost 5 years ago

Tom, everything looks good now. The projects view is much better now with centered horizontal spinner. No worries about the vertical. I can see either one being functional, so we can leave it alone for now until other people find it annoying, if any.

Interesting use of ajax "always" function.

One comment: It seems like you have some tab characters instead of spaces in the updated infinite_scroll.rb. Would you please fix these so that the code is easy to read. Lines 18-29, 36-38, and while at it line 56 onwards.

Other than that, LGTM. Thanks.

#6 Updated by Anonymous almost 5 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 50 to 100

Applied in changeset arvados|commit:f12986389693d4155847204210d9c84492ac6837.

Also available in: Atom PDF