Story #3106

Workbench UI improvement - loading indicator on modals

Added by Radhika Chippada almost 5 years ago. Updated almost 5 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Radhika Chippada
Category:
-
Target version:
Start date:
07/01/2014
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
1.0

Subtasks

Task #3130: Review branch 3106-modal-loading-indicatorResolvedTim Pierce

Associated revisions

Revision 251e6172
Added by Radhika Chippada almost 5 years ago

closes #3106
Merge branch '3106-modal-loading-indicator'

History

#1 Updated by Radhika Chippada almost 5 years ago

  • Status changed from New to In Progress
  • Assigned To set to Radhika Chippada

#2 Updated by Radhika Chippada almost 5 years ago

Branch ready for review:

- Added ajaxStart and ajaxStop event handlers in application.js, which will show / hide the spinner as needed

- Added spinner div to modal dialogs. It appears that there are three files that needed this, all of which are updated.

To test the spinner, the following tests can be used:

- go to <workbench>/pipeline_templates and click on "Run" button. You will see a project chooser dialog. Select a project for this pipeline instance, and you can see the spinner.

- go to <workbench>/users and click on "Add a new user". Enter email and click on Submit button to see the spinner.

#3 Updated by Tim Pierce almost 5 years ago

The code looks good. Only comment:

  • It's unfortunate that displaying the modal spinner causes the list of projects to shift down. Can we display it at the bottom of the menu, or reserve a blank div in its place so that it doesn't displace text? If this is more than about 10 min work then let's just skip it in favor of more urgent tasks.

#4 Updated by Radhika Chippada almost 5 years ago

Addressed your comment. Please take another look. Thanks.

#5 Updated by Tim Pierce almost 5 years ago

LGTM, thanks.

#6 Updated by Tim Pierce almost 5 years ago

Also reviewing 4eaefcfc and dad21a3e65. Still LGTM. :-)

#7 Updated by Radhika Chippada almost 5 years ago

  • Status changed from In Progress to Resolved

Applied in changeset arvados|commit:251e61720f091da260166ae013bdccad6bd173ba.

Also available in: Atom PDF