Bug #3136
closed
[Crunch] Job state is stale in Workbench pipeline instance views, if the job's state changes after the pipeline instance stops.
Added by Peter Amstutz over 10 years ago.
Updated about 10 years ago.
Description
Steps to reproduce:
- Run a pipeline
- Hit "Stop". This doesn't actually cancel the running jobs, see Bug #3165
- Go to the individual job page and cancel the job.
- Since the arv-run-pipeline-instance is no longer updating the copy of the job information in the pipeline instance record (why should it, it's stopped, right?) the pipeline will continue to show the job as running.
Quick resolution:
- In Workbench, look up each job by UUID instead of rendering the copy of the job record stored in the pipeline instance.
- Subject changed from Canceled jobs are shown as running in Workbench to Canceled jobs are shown as running in Workbench [where?]
- Subject changed from Canceled jobs are shown as running in Workbench [where?] to Canceled jobs are shown as still running in Workbench pipeline instance views
- Description updated (diff)
- Subject changed from Canceled jobs are shown as still running in Workbench pipeline instance views to Job state is stale in Workbench pipeline instance views, if the job's state changes after the pipeline instance stops.
- Target version set to 2014-08-06 Sprint
- Subject changed from Job state is stale in Workbench pipeline instance views, if the job's state changes after the pipeline instance stops. to [Crunch] Job state is stale in Workbench pipeline instance views, if the job's state changes after the pipeline instance stops.
- Category set to Crunch
- Description updated (diff)
- Story points changed from 2.0 to 1.0
- Assigned To set to Peter Amstutz
- Target version changed from 2014-08-06 Sprint to 2014-08-27 Sprint
Reviewing the quick Workbench fix at aa0ae05
jobuuids = object.components.select { |cname, c| c[:job] and c[:job][:uuid] }
Since jobuuids gets passed into Job.where, it looks to me like it should be an array, but select will give you a subset of the hash. Should this be object.components.map { … }.compact?
pj[:job] = job[c[:job][:uuid]]
Please check that we actually found a matching job before making this assignment. It's not guaranteed, and if we didn't, the method will crash trying to run nil[:success] a little later.
Thanks.
- Status changed from New to In Progress
- Status changed from In Progress to New
- Status changed from New to Resolved
Applied in changeset arvados|commit:a17b176ea55dc3820ef1bde4b99cf33c628ffbbe.
Also available in: Atom
PDF
Updated by 
Updated by 
Updated by Radhika Chippada 
Updated by 
Updated by Anonymous