[Workbench] UI improvements: Persistent top nav between pages
- Display "loading" indication,
- Do an AJAX call to load just the "body-content DIV" part of the desired page,
- Replace the current body-content div with the new one.
The "wiselinks" gem can do most of this work for us, and lets us enable it selectively so we don't unwittingly break a bunch of stuff (which is what will happen if we turn on "turbolinks").Caveats:
- Also won't play well with "change breadcrumbs depending on which page you're looking at" system
#8 Updated by Brett Smith almost 6 years ago
- The loading animation does not work intended on my Firefox 30. When a wiselink is clicked, the old content is wiped out and then immediately fades back in. The new content renders whenever it arrives in the browser. One idea: would it maybe help if you fade out on a page:loading event, and fade in on page:always or page:done?
- The documentation indicates that wiselink event handlers must manually fill in analytics details. I wonder if the same is true in our case as well—especially since the branch moves
piwik_tracking_tagto the page head, where it won't be reloaded when wiselinks are followed. Is there any way for us to be sure that this branch doesn't interfere with analytics?
#9 Updated by Radhika Chippada almost 6 years ago
- Status changed from In Progress to Resolved
When wiselinks is initialized, selection.js is not working. Tom and I discussed this. According to Tom, we want to stop using selection.js very soon. Hence, we do not want to invest time now to make selection.js to work when wiselinks is on. Hence, for the time being, I commented out wiselinks object initialization. We will turn it on when we resolve the selection.js issue.