Story #3140

[Workbench] UI enhancements: Split project contents into separate tabs and clean up "contents" partial

Added by Radhika Chippada almost 6 years ago. Updated almost 6 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Radhika Chippada
Category:
-
Target version:
Start date:
07/03/2014
Due date:
% Done:

100%

Estimated time:
(Total: 1.00 h)
Story points:
1.0

Description

Todo:
  • Convert "Selection..." drop-down from a split button to a regular dropdown button ("Selection... ↓")
  • Move "tab line buttons" to top of page, instead of tab line (probably makes sense to rename that content section).
  • On projects#show page, replace "Contents" tab with four tabs:
    • Data (collections)
    • Jobs and pipelines
    • Pipeline templates
    • Subprojects
  • Remove the "show [everything/data/jobs/...]" filtering widget

Subtasks

Task #3181: Review branch 3140-project-content-tabsResolvedTim Pierce

Task #3277: Review latest 3140-project-content-tabsResolvedRadhika Chippada

Associated revisions

Revision 9e24edb1
Added by Radhika Chippada almost 6 years ago

closes #3140
Merge branch '3140-project-content-tabs'

Revision 7d5a2544
Added by Radhika Chippada almost 6 years ago

refs #3140
Revert back the UI to display only one tab instead of 5 content tabs since it is not working when accessing a project with large amounts of data.
Merge branch '3140-undo-project-content-tabs'

Revision 964350f4
Added by Radhika Chippada almost 6 years ago

closes #3140
Merge branch '3140-project-content-tabs'

History

#1 Updated by Radhika Chippada almost 6 years ago

  • Assigned To set to Radhika Chippada

#2 Updated by Tom Clegg almost 6 years ago

  • Subject changed from Workbench UI enhancements: "Do stuff with selection" widget has no reason to be a split button to Workbench UI enhancements: Split project contents into separate tabs and clean up "contents" partial
  • Description updated (diff)

#3 Updated by Radhika Chippada almost 6 years ago

  • Status changed from New to In Progress

#4 Updated by Radhika Chippada almost 6 years ago

Also add "Other objects" tab - a catch all for objects not included in the other 4 content tabs (such as humans, traits, specimens etc).

#5 Updated by Radhika Chippada almost 6 years ago

Branch ready for review.

All items listed in description are addressed. However, I think there is opportunity to improve workbench UI in regards to "Move 'tab line buttons' to top of page". There seems to be too much unused white space to the right of name and description. I think it would be desirable that we move the "tab line buttons" for the entire application into this area. This can make more of the screen available for actual content display.

Should we run this idea by Tom O'Keefe?

#6 Updated by Tim Pierce almost 6 years ago

Review at 3b7eb34eed:

Radhika Chippada wrote:

Branch ready for review.

All items listed in description are addressed. However, I think there is opportunity to improve workbench UI in regards to "Move 'tab line buttons' to top of page". There seems to be too much unused white space to the right of name and description. I think it would be desirable that we move the "tab line buttons" for the entire application into this area. This can make more of the screen available for actual content display.

Should we run this idea by Tom O'Keefe?

That seems like a good issue for Tom to work on. We should certainly have those buttons in a consistent place across our views as much as possible, and for now I think what you've done with them makes the most sense.

The code here LGTM, okay to merge.

#7 Updated by Radhika Chippada almost 6 years ago

  • Status changed from In Progress to Resolved

Applied in changeset arvados|commit:9e24edb1d9624b6aed38464c70cab5027586abbc.

#8 Updated by Peter Amstutz almost 6 years ago

  • Status changed from Resolved to In Progress

Reopened. Tabs are not displaying the expected contents:

https://workbench.4xphq.arvadosapi.com/projects/4xphq-j7d0g-ur9v47pkvxu1hds

Also in the "Jobs and pipelines" tab, please display pipelines before jobs.

#9 Updated by Radhika Chippada almost 6 years ago

  • Story points changed from 1.0 to 2.0

The initial implementation is not working correctly. It seems to be due to infinite scrolling and caching, the multiple tabs are showing same data when there is a lot of data in the project.

Need to improve the page content to prevent mixing of data.

#10 Updated by Radhika Chippada almost 6 years ago

  • Target version changed from 2014-07-16 Sprint to 2014-08-06 Sprint

#11 Updated by Ward Vandewege almost 6 years ago

  • Subject changed from Workbench UI enhancements: Split project contents into separate tabs and clean up "contents" partial to [Workbench] UI enhancements: Split project contents into separate tabs and clean up "contents" partial

#12 Updated by Tom Clegg almost 6 years ago

  • Story points changed from 2.0 to 1.0

#13 Updated by Radhika Chippada almost 6 years ago

Regarding Peter's comment #8: Ward and Tom disagreed with showing pipeline instances before jobs.

#14 Updated by Tim Pierce almost 6 years ago

LGTM at a7824d5.

#15 Updated by Radhika Chippada almost 6 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 50 to 100

Applied in changeset arvados|commit:964350f4132788e07a7ce1b159179a152e9cfcdc.

Also available in: Atom PDF