Bug #3178
closed
Discovery document does not publish optional parameters "find_or_create", "filters", "minimum_script_version", and "exclude_script_versions" for the Job "create" method.
Description
Because these parameters are not published, you can't use from from the 'arv' command line (and presumably most the rest of the SDK.)
Updated by
Updated by Tom Clegg almost 10 years ago
- Target version set to Arvados Future Sprints
Updated by Tom Clegg over 9 years ago
- Target version changed from Arvados Future Sprints to 2014-08-27 Sprint
Updated by Tim Pierce
Updated by Brett Smith over 9 years ago
Reviewing fd38dca
The code looks good, but _setup_requires_parameters seems not to work as intended. When I restart the API server from this branch, those parameters don't appear in the discovery document; only send_notification_email appears for Users#setup. (The new Job#create parameters do appear.) Please take another look, and let me know if you need help to see what I'm seeing.
Updated by Tom Clegg over 9 years ago
Brett Smith wrote:
Ahem. Found two reasons:The code looks good, but
_setup_requires_parametersseems not to work as intended. When I restart the API server from this branch, those parameters don't appear in the discovery document; onlysend_notification_emailappears for Users#setup. (The new Job#create parameters do appear.) Please take another look, and let me know if you need help to see what I'm seeing.
- I made an instance method instead of a class method.
- There was already a class method there, with send_notification_email but not the other parameters.
So I merged the new content into the existing class method.
Now at 2bec2ba
Updated by Brett Smith over 9 years ago
Updated by Anonymous over 9 years ago
- Status changed from In Progress to Resolved
- % Done changed from 33 to 100
Applied in changeset arvados|commit:57ee96926d2d3d315ece3b2cbfb20d0fe01ab912.