https://dev.arvados.org/https://dev.arvados.org/favicon.ico?15576888422014-07-03T13:30:02ZArvadosArvados - Bug #3178: Discovery document does not publish optional parameters "find_or_create", "filters", "minimum_script_version", and "exclude_script_versions" for the Job "create" method.https://dev.arvados.org/issues/3178?journal_id=118782014-07-03T13:30:02ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/11878/diff?detail_id=10208">diff</a>)</li></ul> Arvados - Bug #3178: Discovery document does not publish optional parameters "find_or_create", "filters", "minimum_script_version", and "exclude_script_versions" for the Job "create" method.https://dev.arvados.org/issues/3178?journal_id=119572014-07-04T15:02:28ZTom Cleggtom@curii.com
<ul><li><strong>Target version</strong> set to <i>Arvados Future Sprints</i></li></ul> Arvados - Bug #3178: Discovery document does not publish optional parameters "find_or_create", "filters", "minimum_script_version", and "exclude_script_versions" for the Job "create" method.https://dev.arvados.org/issues/3178?journal_id=129242014-07-31T11:26:42ZTom Cleggtom@curii.com
<ul><li><strong>Target version</strong> changed from <i>Arvados Future Sprints</i> to <i>2014-08-27 Sprint</i></li></ul> Arvados - Bug #3178: Discovery document does not publish optional parameters "find_or_create", "filters", "minimum_script_version", and "exclude_script_versions" for the Job "create" method.https://dev.arvados.org/issues/3178?journal_id=129252014-07-31T11:26:52ZTom Cleggtom@curii.com
<ul><li><strong>Story points</strong> set to <i>0.5</i></li></ul> Arvados - Bug #3178: Discovery document does not publish optional parameters "find_or_create", "filters", "minimum_script_version", and "exclude_script_versions" for the Job "create" method.https://dev.arvados.org/issues/3178?journal_id=132172014-08-06T15:35:40ZBrett Smithbrett.smith@curii.com
<ul><li><strong>Assigned To</strong> set to <i>Brett Smith</i></li></ul> Arvados - Bug #3178: Discovery document does not publish optional parameters "find_or_create", "filters", "minimum_script_version", and "exclude_script_versions" for the Job "create" method.https://dev.arvados.org/issues/3178?journal_id=132192014-08-06T15:37:17ZBrett Smithbrett.smith@curii.com
<ul><li><strong>Assigned To</strong> deleted (<del><i>Brett Smith</i></del>)</li></ul> Arvados - Bug #3178: Discovery document does not publish optional parameters "find_or_create", "filters", "minimum_script_version", and "exclude_script_versions" for the Job "create" method.https://dev.arvados.org/issues/3178?journal_id=132582014-08-06T16:08:58ZTim Piercetwp@curoverse.com
<ul><li><strong>Category</strong> set to <i>API</i></li></ul> Arvados - Bug #3178: Discovery document does not publish optional parameters "find_or_create", "filters", "minimum_script_version", and "exclude_script_versions" for the Job "create" method.https://dev.arvados.org/issues/3178?journal_id=132872014-08-06T16:29:07ZTom Cleggtom@curii.com
<ul><li><strong>Assigned To</strong> set to <i>Tom Clegg</i></li></ul> Arvados - Bug #3178: Discovery document does not publish optional parameters "find_or_create", "filters", "minimum_script_version", and "exclude_script_versions" for the Job "create" method.https://dev.arvados.org/issues/3178?journal_id=134582014-08-10T18:17:01ZTom Cleggtom@curii.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li></ul> Arvados - Bug #3178: Discovery document does not publish optional parameters "find_or_create", "filters", "minimum_script_version", and "exclude_script_versions" for the Job "create" method.https://dev.arvados.org/issues/3178?journal_id=134952014-08-11T13:14:01ZBrett Smithbrett.smith@curii.com
<ul></ul><p>Reviewing <a class="changeset" title="3178: Discover required parameters for regular CRUD methods, too." href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/fd38dcafdb0b89aff5f722946c7326291ad69290">fd38dca</a></p>
<p>The code looks good, but <code>_setup_requires_parameters</code> seems not to work as intended. When I restart the API server from this branch, those parameters don't appear in the discovery document; only <code>send_notification_email</code> appears for Users#setup. (The new Job#create parameters do appear.) Please take another look, and let me know if you need help to see what I'm seeing.</p> Arvados - Bug #3178: Discovery document does not publish optional parameters "find_or_create", "filters", "minimum_script_version", and "exclude_script_versions" for the Job "create" method.https://dev.arvados.org/issues/3178?journal_id=135232014-08-11T19:05:21ZTom Cleggtom@curii.com
<ul></ul><p>Brett Smith wrote:</p>
<blockquote>
<p>The code looks good, but <code>_setup_requires_parameters</code> seems not to work as intended. When I restart the API server from this branch, those parameters don't appear in the discovery document; only <code>send_notification_email</code> appears for Users#setup. (The new Job#create parameters do appear.) Please take another look, and let me know if you need help to see what I'm seeing.</p>
</blockquote>
Ahem. Found two reasons:
<ol>
<li>I made an instance method instead of a class method.</li>
<li>There was already a class method there, with send_notification_email but not the other parameters.</li>
</ol>
<p>So I merged the new content into the existing class method.</p>
<p>Now at <a class="changeset" title="3178: Merge bogus _setup_requires_parameters into existing class method." href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/2bec2ba1ce3b37fb8ff9a94f20d6c8a694d87183">2bec2ba</a></p> Arvados - Bug #3178: Discovery document does not publish optional parameters "find_or_create", "filters", "minimum_script_version", and "exclude_script_versions" for the Job "create" method.https://dev.arvados.org/issues/3178?journal_id=135332014-08-12T09:17:18ZBrett Smithbrett.smith@curii.com
<ul></ul><p>Tom Clegg wrote:</p>
<blockquote>
<p>Now at <a class="changeset" title="3178: Merge bogus _setup_requires_parameters into existing class method." href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/2bec2ba1ce3b37fb8ff9a94f20d6c8a694d87183">2bec2ba</a></p>
</blockquote>
<p>This looks good to merge to me. Thanks.</p> Arvados - Bug #3178: Discovery document does not publish optional parameters "find_or_create", "filters", "minimum_script_version", and "exclude_script_versions" for the Job "create" method.https://dev.arvados.org/issues/3178?journal_id=135412014-08-12T10:15:09ZAnonymous
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Resolved</i></li><li><strong>% Done</strong> changed from <i>33</i> to <i>100</i></li></ul><p>Applied in changeset arvados|commit:57ee96926d2d3d315ece3b2cbfb20d0fe01ab912.</p>