Bug #3178
closed
Discovery document does not publish optional parameters "find_or_create", "filters", "minimum_script_version", and "exclude_script_versions" for the Job "create" method.
Added by Peter Amstutz almost 11 years ago.
Updated over 10 years ago.
Description
Because these parameters are not published, you can't use from from the 'arv' command line (and presumably most the rest of the SDK.)
- Description updated (diff)
- Target version set to Arvados Future Sprints
- Target version changed from Arvados Future Sprints to 2014-08-27 Sprint
- Assigned To set to Brett Smith
- Assigned To deleted (
Brett Smith)
- Assigned To set to Tom Clegg
- Status changed from New to In Progress
Reviewing fd38dca
The code looks good, but _setup_requires_parameters
seems not to work as intended. When I restart the API server from this branch, those parameters don't appear in the discovery document; only send_notification_email
appears for Users#setup. (The new Job#create parameters do appear.) Please take another look, and let me know if you need help to see what I'm seeing.
Brett Smith wrote:
The code looks good, but _setup_requires_parameters
seems not to work as intended. When I restart the API server from this branch, those parameters don't appear in the discovery document; only send_notification_email
appears for Users#setup. (The new Job#create parameters do appear.) Please take another look, and let me know if you need help to see what I'm seeing.
Ahem. Found two reasons:
- I made an instance method instead of a class method.
- There was already a class method there, with send_notification_email but not the other parameters.
So I merged the new content into the existing class method.
Now at 2bec2ba
Tom Clegg wrote:
Now at 2bec2ba
This looks good to merge to me. Thanks.
- Status changed from In Progress to Resolved
- % Done changed from 33 to 100
Applied in changeset arvados|commit:57ee96926d2d3d315ece3b2cbfb20d0fe01ab912.
Also available in: Atom
PDF