Arvados

Plan:

• Use collapsible panels for each component. Show summary at the top, user can click to expand and get details.
• Use advanced log viewer for live log view. Add feature to filter by job.
• Use single set of erb templates for job/template, render single job by creating stand-in pipeline instance?
• Do something useful with crunchstat.

• Adjust timestamps using JS to use local timezone instead of displaying UTC.

Also show queue position of queued jobs.

Peter,
I may not have done a great job of reviewing any potential issues with the updates. However, I have a few comments based on my reading through the code and testing:

• apps/workbench/app/assets/javascripts/dates.js
  • Forgotten console.log statement?
  • if you want to keep it, what are you trying to log? Can you please make it more descriptive?
  • Way too many “woble!” lines when I run the tests :)
  • “var re” can you call it “regexp” or “date_regexp”? I would also prefer we call “var v” as “var matches” or something like that.

• pipeline_instances_helper.rb:
  • merge_range method - what is “j” referenced in comments?
  • determine_wallclock_runtime method
    • What is the input for this method? Is it “job” or range? In the PipelineInstancesControllerTest, you call the input to this method as “r”, which makes me wonder if it is “range”. Also, can you please use a more explanatory name in the test, such as “range” or “time_range” instead of “r”?
    • Forgotten “puts” statement in this method?
  • runtime method
    • It appears that this is not returning the pipeline’s runtime. Can you use a more descriptive name for this method? May be something like “component_runtime”?
    • It appears that the method parameter “long” indicates that the user wants a long description of the runtime duration? How about a name such as “long_description”? “long” on its own feels so confusing with number-like keyword

• apps/workbench/app/views/pipeline_instances/_show_components_running.html.erb
  • Forgotten puts statement at lines 56 and 85?
  • indentation off at line 49

• Question about nil check
  • Can “if not job[:cancelled_at].nil?” be simplified as “if !job[:cancelled_at]” ? There were a few such cases and just want to see if we can improve readability.

• Pipeline UI: The “Components” tab has text “Has not started. . .”. This pipeline summary needs to be a bit more descriptive. Right now, I could not understand what it is telling me.

• Advanced tab: Can we rename “curl example” as “Curl example” so that it looks similar to the other accordion titles? I looked at curl “man” page and it does use “Curl” some places and hence I think it does not seem too offensive to use the uppercase letter.

• Two failing integration tests:
  • PipelineInstancesTest#test_Create_and_run_a_pipeline:
    test/integration/pipeline_instances_test.rb:78:in `block in <class:PipelineInstancesTest>'
  • PipelineInstancesTest#test_Create_pipeline_inside_a_project_and_run:
    test/integration/pipeline_instances_test.rb:141:in `block in <class:PipelineInstancesTest>'