Arvados

Comments on 0fe8a55

• From an code maintainability perspective, I don't understand why it's helpful to separate render_textile_attribute from render_textile_if_textile (the names make it difficult to remember the difference, since they have such similar signatures). My personal feeling is that it'd be simpler to make render_textile_if_textile a public method, add truncate=false to its arguments, and have one method cover both cases. Is there some reason this isn't appropriate?
• The new tests check for misrendering twice. Please remove one of these assertions—probably the first one, since the second one checks the whole page.

Thanks.

Brett:

1. I did some refactoring and tightening of the code, and also renamed the method.

2. I removed the extra check. An also, improved the test to verify that description is truncated.

Radhika,

Thanks very much for these changes (d199bf8). I like this branch a lot. There's just one small typo in the current version: the tests add a <p/> to the project description that should be </p>. Please go ahead and merge with that fix. Thanks again.