Actions
Bug #3339
closed[Workbench] Project descriptions on the dashboard should be truncated at the first paragraph break.
Status:
Resolved
Priority:
Normal
Assigned To:
Radhika Chippada
Category:
Workbench
Target version:
Start date:
08/25/2014
Due date:
% Done:
100%
Estimated time:
(Total: 0.00 h)
Story points:
0.5
Updated by Tom Clegg over 9 years ago
- Subject changed from [Workbench] Project descriptions on the dashboard should only show the first sentence or first N characters of the project description. to [Workbench] Project descriptions on the dashboard should be truncated at the first empty line.
Updated by Radhika Chippada over 9 years ago
- Assigned To set to Radhika Chippada
Updated by Tom Clegg over 9 years ago
- Subject changed from [Workbench] Project descriptions on the dashboard should be truncated at the first empty line. to [Workbench] Project descriptions on the dashboard should be truncated at the first paragraph break.
Updated by Radhika Chippada over 9 years ago
- Status changed from New to In Progress
Updated by Brett Smith over 9 years ago
Comments on 0fe8a55
- From an code maintainability perspective, I don't understand why it's helpful to separate
render_textile_attribute
fromrender_textile_if_textile
(the names make it difficult to remember the difference, since they have such similar signatures). My personal feeling is that it'd be simpler to makerender_textile_if_textile
a public method, addtruncate=false
to its arguments, and have one method cover both cases. Is there some reason this isn't appropriate? - The new tests check for misrendering twice. Please remove one of these assertions—probably the first one, since the second one checks the whole page.
Thanks.
Updated by Radhika Chippada over 9 years ago
Brett:
1. I did some refactoring and tightening of the code, and also renamed the method.
2. I removed the extra check. An also, improved the test to verify that description is truncated.
Updated by Brett Smith over 9 years ago
Radhika,
Thanks very much for these changes (d199bf8). I like this branch a lot. There's just one small typo in the current version: the tests add a <p/>
to the project description that should be </p>
. Please go ahead and merge with that fix. Thanks again.
Updated by Radhika Chippada over 9 years ago
- Status changed from In Progress to Resolved
Applied in changeset arvados|commit:d1f510e7fa9f1b2656c54c1e9b3ea4e4466c9d1e.
Actions