[Workbench] Project descriptions on the dashboard should be truncated at the first paragraph break.
#8 Updated by Brett Smith almost 6 years ago
Comments on 0fe8a55
- From an code maintainability perspective, I don't understand why it's helpful to separate
render_textile_if_textile(the names make it difficult to remember the difference, since they have such similar signatures). My personal feeling is that it'd be simpler to make
render_textile_if_textilea public method, add
truncate=falseto its arguments, and have one method cover both cases. Is there some reason this isn't appropriate?
- The new tests check for misrendering twice. Please remove one of these assertions—probably the first one, since the second one checks the whole page.
#10 Updated by Brett Smith almost 6 years ago
Thanks very much for these changes (d199bf8). I like this branch a lot. There's just one small typo in the current version: the tests add a
<p/> to the project description that should be
</p>. Please go ahead and merge with that fix. Thanks again.