Bug #3421

[Workbench] "Rename collection" button on project page is hidden/inaccessible if the current name is too long and the browser window is too narrow.

Added by Tom Clegg about 5 years ago. Updated about 5 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Brett Smith
Category:
Workbench
Target version:
Start date:
08/13/2014
Due date:
% Done:

100%

Estimated time:
(Total: 1.00 h)
Story points:
0.5

Subtasks

Task #3584: Review 3421-wide-project-tables-wipResolvedBrett Smith


Related issues

Related to Arvados - Bug #3344: [Workbench] Cannot [figure out how to] rename a collection created by arv-put with no --name provided.Resolved07/24/2014

Associated revisions

Revision 74824103
Added by Brett Smith about 5 years ago

Merge branch '3421-wide-project-tables-wip'

Closes #3421, #3584.

History

#1 Updated by Brett Smith about 5 years ago

  • Assigned To set to Brett Smith

#2 Updated by Tim Pierce about 5 years ago

  • Category set to Workbench

#3 Updated by Brett Smith about 5 years ago

There isn't one obviously right way to fix this bug. The project contents tables have fixed layouts, meaning each td has white-space: nowrap; overflow: hidden; set. And these tables just use render_editable_attribute to render this name, meaning we can't change the layout of the name+pencil pair without far-reaching consequences. I have not found any way to say "If the contents of this box overflow, render this content at the end" in CSS.

Does this table need to have a fixed layout (i.e., each row is the same height)? Removing that constraint would make for the easiest, and most flexible fix. Judiciously adding  s to the row contents would help prevent awkward wraps between buttons, etc.

If the table should have a fixed layout, then I think our next best option is to stop using the application-wide table-fixedlayout class, and write more specialized CSS for these tables.

We could pass render_editable_attribute the option to render the pencil on the left of the name instead of the right, but while that's very simple code-wise I think the UI inconsistency would be really jarring to users.

#4 Updated by Brett Smith about 5 years ago

  • Status changed from New to In Progress

#5 Updated by Brett Smith about 5 years ago

At sprint planning nobody wanted to get too deep into this, so I was given unilateral authority to solve it however I think best.

#6 Updated by Brett Smith about 5 years ago

  • Status changed from In Progress to New

Setting the status back to New for the time being because while I've thought about this, no code has been changed yet, and it's going to be a bit before I get to it again.

#7 Updated by Brett Smith about 5 years ago

  • Status changed from New to In Progress

#8 Updated by Peter Amstutz about 5 years ago

2ad9c20601673674ad787e2457445b6c1a0e9212

I'm glad you were able to find a good solution. Looks good to me.

#9 Updated by Brett Smith about 5 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100

Applied in changeset arvados|commit:7482410350df49dbddab05448b167bf61f14d71e.

Also available in: Atom PDF