https://dev.arvados.org/https://dev.arvados.org/favicon.ico?15576888422014-08-06T15:27:25ZArvadosArvados - Bug #3421: [Workbench] "Rename collection" button on project page is hidden/inaccessible if the current name is too long and the browser window is too narrow.https://dev.arvados.org/issues/3421?journal_id=132112014-08-06T15:27:25ZBrett Smithbrett.smith@curii.com
<ul><li><strong>Assigned To</strong> set to <i>Brett Smith</i></li></ul> Arvados - Bug #3421: [Workbench] "Rename collection" button on project page is hidden/inaccessible if the current name is too long and the browser window is too narrow.https://dev.arvados.org/issues/3421?journal_id=132312014-08-06T15:45:58ZTim Piercetwp@curoverse.com
<ul><li><strong>Category</strong> set to <i>Workbench</i></li></ul> Arvados - Bug #3421: [Workbench] "Rename collection" button on project page is hidden/inaccessible if the current name is too long and the browser window is too narrow.https://dev.arvados.org/issues/3421?journal_id=133422014-08-07T12:26:50ZBrett Smithbrett.smith@curii.com
<ul></ul><p>There isn't one obviously right way to fix this bug. The project contents tables have fixed layouts, meaning each td has <code>white-space: nowrap; overflow: hidden;</code> set. And these tables just use <code>render_editable_attribute</code> to render this name, meaning we can't change the layout of the name+pencil pair without far-reaching consequences. I have not found any way to say "If the contents of this box overflow, render this content at the end" in CSS.</p>
<p>Does this table need to have a fixed layout (i.e., each row is the same height)? Removing that constraint would make for the easiest, and most flexible fix. Judiciously adding s to the row contents would help prevent awkward wraps between buttons, etc.</p>
<p>If the table should have a fixed layout, then I think our next best option is to stop using the application-wide <code>table-fixedlayout</code> class, and write more specialized CSS for these tables.</p>
<p>We could pass <code>render_editable_attribute</code> the option to render the pencil on the left of the name instead of the right, but while that's very simple code-wise I think the UI inconsistency would be really jarring to users.</p> Arvados - Bug #3421: [Workbench] "Rename collection" button on project page is hidden/inaccessible if the current name is too long and the browser window is too narrow.https://dev.arvados.org/issues/3421?journal_id=133432014-08-07T13:54:24ZBrett Smithbrett.smith@curii.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li></ul> Arvados - Bug #3421: [Workbench] "Rename collection" button on project page is hidden/inaccessible if the current name is too long and the browser window is too narrow.https://dev.arvados.org/issues/3421?journal_id=134612014-08-11T08:19:46ZBrett Smithbrett.smith@curii.com
<ul></ul><p>At sprint planning nobody wanted to get too deep into this, so I was given unilateral authority to solve it however I think best.</p> Arvados - Bug #3421: [Workbench] "Rename collection" button on project page is hidden/inaccessible if the current name is too long and the browser window is too narrow.https://dev.arvados.org/issues/3421?journal_id=134622014-08-11T08:20:24ZBrett Smithbrett.smith@curii.com
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>New</i></li></ul><p>Setting the status back to New for the time being because while I've thought about this, no code has been changed yet, and it's going to be a bit before I get to it again.</p> Arvados - Bug #3421: [Workbench] "Rename collection" button on project page is hidden/inaccessible if the current name is too long and the browser window is too narrow.https://dev.arvados.org/issues/3421?journal_id=135732014-08-12T15:45:13ZBrett Smithbrett.smith@curii.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li></ul> Arvados - Bug #3421: [Workbench] "Rename collection" button on project page is hidden/inaccessible if the current name is too long and the browser window is too narrow.https://dev.arvados.org/issues/3421?journal_id=136192014-08-13T15:12:13ZPeter Amstutzpeter.amstutz@curii.com
<ul></ul><p><a class="changeset" title="3421: Make Workbench project contents tables variable width. This change will ensure that users ..." href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/2ad9c20601673674ad787e2457445b6c1a0e9212">2ad9c20601673674ad787e2457445b6c1a0e9212</a></p>
<p>I'm glad you were able to find a good solution. Looks good to me.</p> Arvados - Bug #3421: [Workbench] "Rename collection" button on project page is hidden/inaccessible if the current name is too long and the browser window is too narrow.https://dev.arvados.org/issues/3421?journal_id=136342014-08-13T16:40:15ZBrett Smithbrett.smith@curii.com
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Resolved</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>Applied in changeset arvados|commit:7482410350df49dbddab05448b167bf61f14d71e.</p>