Feature #3454

[API] Assign a system-default default docker image (instead of using the non-docker code path) if none is specified in runtime_constraints.

Added by Peter Amstutz about 7 years ago. Updated over 6 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Radhika Chippada
Category:
API
Target version:
Start date:
05/07/2015
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
0.5

Subtasks

Task #5942: Review branch: 3454-default-docker-imageResolvedRadhika Chippada


Related issues

Related to Arvados - Bug #5990: [SDKs] arv-run defaults to using arvados/jobs, without checking that it exists or is recentResolved05/25/201505/25/2015

Related to Arvados - Feature #6348: [Deployment] [Documentation] Minimize system-wide dependencies for compute node setupNew06/18/2015

Associated revisions

Revision 1cea1923
Added by Radhika Chippada over 6 years ago

closes #3454
Merge branch '3454-default-docker-image'

History

#1 Updated by Peter Amstutz about 7 years ago

  • Subject changed from Reject jobs that are missing docker_image in runtime_constraints. to [API] Reject jobs that are missing docker_image in runtime_constraints.
  • Category set to API

#2 Updated by Tom Clegg almost 7 years ago

  • Tracker changed from Bug to Feature

#3 Updated by Tom Clegg almost 7 years ago

  • Target version set to Arvados Future Sprints

#4 Updated by Tom Clegg over 6 years ago

  • Subject changed from [API] Reject jobs that are missing docker_image in runtime_constraints. to [API] Assign a system-default default docker image (instead of using the non-docker code path) if none is specified in runtime_constraints.
  • Story points set to 0.5

#5 Updated by Tom Clegg over 6 years ago

  • Target version changed from Arvados Future Sprints to 2015-05-20 sprint

#6 Updated by Radhika Chippada over 6 years ago

  • Assigned To set to Radhika Chippada

#7 Updated by Radhika Chippada over 6 years ago

  • Status changed from New to In Progress

#8 Updated by Peter Amstutz over 6 years ago

  • If Rails.configuration.default_docker_image_for_jobs is false, and docker_image is not set in the job, that should probably be a validation error instead of falling back to the old behavior (running in a non-Docker configuration)
  • Instead of runtime_constraints.is_a? Hash suggest setting runtime_constraints ||= {}

#9 Updated by Radhika Chippada over 6 years ago

I observed that making the job invalid when "no default config + runtime_constraints not including docker image" is a very drastic change. A large number of tests failed without the default config.

This made me wonder if we will have the very undesirable side effect of not being able to access jobs when the system does not have the default config.

I discussed this with Peter, and we decided to not do this as part of this update (the feature does not ask for it).

If we want this, we will address it in a different feature request.

#10 Updated by Radhika Chippada over 6 years ago

  • Status changed from In Progress to Resolved

Applied in changeset arvados|commit:1cea19230b490876f99194ea4d84970d6330ae12.

Also available in: Atom PDF