Bug #3489
[Workbench] Collection chooser starts at "All projects" but doesn't show any collections.
Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench
Target version:
Start date:
08/08/2014
Due date:
% Done:
100%
Estimated time:
(Total: 3.00 h)
Story points:
0.5
Subtasks
Associated revisions
Merge branch '3489-indicate-initial-project-filter' closes #3489
History
#1
Updated by Peter Amstutz over 6 years ago
- Category set to Workbench
#2
Updated by Tom Clegg over 6 years ago
- Assigned To set to Tom Clegg
- Target version set to 2014-08-27 Sprint
#3
Updated by Tom Clegg over 6 years ago
- Story points set to 0.5
#4
Updated by Tom Clegg over 6 years ago
- Status changed from New to In Progress
#5
Updated by Brett Smith over 6 years ago
Reviewing b79c440
Group.find?(val).name
will crash if it fails to find something, since it ends up callingnil.name
. I think this should beGroup.find(val).name rescue "Group Projects"
(or some other default).- The comment with @filters.inspect is effectively a debug statement that should be removed. :)
- Can we write a test for this?
#6
Updated by Tom Clegg over 6 years ago
Brett Smith wrote:
Group.find?(val).name
will crash if it fails to find something, since it ends up callingnil.name
. I think this should beGroup.find(val).name rescue "Group Projects"
(or some other default).
Used find(val).name rescue val
-- i.e., if the project became unfindable then you just see its UUID.
- The comment with @filters.inspect is effectively a debug statement that should be removed. :)
Indeed. Removed.
- Can we write a test for this?
Indeed. Added an assert_selector in the pipeline_instances megatest.
Now at aa923c9
#7
Updated by Brett Smith over 6 years ago
I think aa923c9 is good to merge. Thanks.
#8
Updated by Anonymous over 6 years ago
- Status changed from In Progress to Resolved
Applied in changeset arvados|commit:a6010696b246cc43c721a35d56179c629d54e798.
Fix excessive API calls in collection chooser. refs #3489