Project

General

Profile

Actions
Copy link

Bug #3489

closed

[Workbench] Collection chooser starts at "All projects" but doesn't show any collections.

Added by Peter Amstutz over 9 years ago. Updated over 9 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Tom Clegg
Category:
Workbench
Target version:
2014-08-27 Sprint
Start date:
08/08/2014
Due date:
% Done:

100%

Estimated time:
(Total: 3.00 h)
Story points:
0.5

Subtasks 3 (0 open — 3 closed)

Task #3539: Reproduce problemResolvedTom Clegg08/08/2014

Actions
Task #3544: Indicate preselected project (if any) in chooser instead of always showing "All projects" at firstResolvedTom Clegg08/08/2014

Actions
Task #3545: Review 3489-indicate-initial-project-filterResolvedTom Clegg08/08/2014

Actions
Actions
Copy link
 #1

Updated by Peter Amstutz over 9 years ago

  • Category set to Workbench
Actions
Copy link
 #2

Updated by Tom Clegg over 9 years ago

  • Assigned To set to Tom Clegg
  • Target version set to 2014-08-27 Sprint
Actions
Copy link
 #3

Updated by Tom Clegg over 9 years ago

  • Story points set to 0.5
Actions
Copy link
 #4

Updated by Tom Clegg over 9 years ago

  • Status changed from New to In Progress
Actions
Copy link
 #5

Updated by Brett Smith over 9 years ago

Reviewing b79c440

  • Group.find?(val).name will crash if it fails to find something, since it ends up calling nil.name. I think this should be Group.find(val).name rescue "Group Projects" (or some other default).
  • The comment with @filters.inspect is effectively a debug statement that should be removed. :)
  • Can we write a test for this?
Actions
Copy link
 #6

Updated by Tom Clegg over 9 years ago

Brett Smith wrote:

  • Group.find?(val).name will crash if it fails to find something, since it ends up calling nil.name. I think this should be Group.find(val).name rescue "Group Projects" (or some other default).

Used find(val).name rescue val -- i.e., if the project became unfindable then you just see its UUID.

  • The comment with @filters.inspect is effectively a debug statement that should be removed. :)

Indeed. Removed.

  • Can we write a test for this?

Indeed. Added an assert_selector in the pipeline_instances megatest.

Now at aa923c9

Actions
Copy link
 #7

Updated by Brett Smith over 9 years ago

I think aa923c9 is good to merge. Thanks.

Actions
Copy link
 #8

Updated by Anonymous over 9 years ago

  • Status changed from In Progress to Resolved

Applied in changeset arvados|commit:a6010696b246cc43c721a35d56179c629d54e798.

Actions
Copy link

Also available in: Atom PDF