Arvados

Reviewing b79c440

• Group.find?(val).name will crash if it fails to find something, since it ends up calling nil.name. I think this should be Group.find(val).name rescue "Group Projects" (or some other default).
• The comment with @filters.inspect is effectively a debug statement that should be removed. :)
• Can we write a test for this?

Brett Smith wrote:

• Group.find?(val).name will crash if it fails to find something, since it ends up calling nil.name. I think this should be Group.find(val).name rescue "Group Projects" (or some other default).

Used find(val).name rescue val -- i.e., if the project became unfindable then you just see its UUID.

• The comment with @filters.inspect is effectively a debug statement that should be removed. :)

Indeed. Removed.

• Can we write a test for this?

Indeed. Added an assert_selector in the pipeline_instances megatest.

Now at aa923c9

I think aa923c9 is good to merge. Thanks.