Project

General

Profile

Actions
Copy link

Support #3505

closed

[Sample pipelines] Support science team

Added by Tom Clegg over 9 years ago. Updated over 9 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Tom Clegg
Category:
-
Target version:
2014-08-27 Sprint
Due date:
Story points:
2.0

Subtasks 2 (0 open — 2 closed)

Task #3587: Review 3505-virtual-work-dirResolvedPeter Amstutz08/07/2014Actions
Task #3506: Help Sally/Brian/AbramResolvedTom Clegg08/07/2014Actions

Related issues

Blocked by Arvados - Task #3678: Review multiple-dispatchResolvedWard Vandewege08/25/2014Actions
Actions
Copy link
 #1

Updated by Peter Amstutz over 9 years ago

  • Story points changed from 3.0 to 2.0
Actions
Copy link
 #2

Updated by Ward Vandewege over 9 years ago

  • Subject changed from Support science team to [Sample pipelines] Support science team
Actions
Copy link
 #3

Updated by Peter Amstutz over 9 years ago

  • Assigned To set to Peter Amstutz
Actions
Copy link
 #4

Updated by Peter Amstutz over 9 years ago

  • Status changed from New to In Progress
Actions
Copy link
 #5

Updated by Brett Smith over 9 years ago

Reviewing 3505-virtual-work-dir at 02d6330. Looks pretty good overall, just a few small comments:

  • Would it make sense to organize these Crunch script utility modules, like robust_put and vwd, under a subdirectory of crunch_scripts? I feel like it would be nice if people could ls crunch_scripts and see at a glance a list of the scripts that ship with Arvados. Tucking the non-runnable modules into a subdirectory would make that easier.
  • robust_put's exception handlers use the logging module, but it isn't imported.
  • As a general rule, var is None is more natural Python style than var == None.

Thanks.

Actions
Copy link
 #6

Updated by Brett Smith over 9 years ago

5f62b0c looks good to merge. Thanks.

Actions
Copy link
 #7

Updated by Tom Clegg over 9 years ago

  • Assigned To changed from Peter Amstutz to Tom Clegg
Actions
Copy link
 #8

Updated by Tom Clegg over 9 years ago

  • Status changed from In Progress to Resolved
Actions
Copy link

Also available in: Atom PDF