Support #3505
[Sample pipelines] Support science team
Start date:
08/07/2014
Due date:
% Done:
100%
Estimated time:
(Total: 0.00 h)
Story points:
2.0
Subtasks
Related issues
Associated revisions
History
#1
Updated by Peter Amstutz over 6 years ago
- Story points changed from 3.0 to 2.0
#2
Updated by Ward Vandewege over 6 years ago
- Subject changed from Support science team to [Sample pipelines] Support science team
#3
Updated by Peter Amstutz over 6 years ago
- Assigned To set to Peter Amstutz
#4
Updated by Peter Amstutz over 6 years ago
- Status changed from New to In Progress
#5
Updated by Brett Smith over 6 years ago
Reviewing 3505-virtual-work-dir at 02d6330. Looks pretty good overall, just a few small comments:
- Would it make sense to organize these Crunch script utility modules, like robust_put and vwd, under a subdirectory of crunch_scripts? I feel like it would be nice if people could
ls crunch_scripts
and see at a glance a list of the scripts that ship with Arvados. Tucking the non-runnable modules into a subdirectory would make that easier. - robust_put's exception handlers use the logging module, but it isn't imported.
- As a general rule,
var is None
is more natural Python style thanvar == None
.
Thanks.
#6
Updated by Brett Smith over 6 years ago
5f62b0c looks good to merge. Thanks.
#7
Updated by Tom Clegg over 6 years ago
- Assigned To changed from Peter Amstutz to Tom Clegg
#8
Updated by Tom Clegg over 6 years ago
- Status changed from In Progress to Resolved
Merge branch '3505-virtual-work-dir' refs #3505