Story #3527

[Crunch] Remove check for "docker_image_hash" link when job supplies a keep locator for "docker_image" .

Added by Peter Amstutz about 5 years ago. Updated about 5 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Brett Smith
Category:
Crunch
Target version:
Start date:
08/08/2014
Due date:
% Done:

100%

Estimated time:
(Total: 1.00 h)
Story points:
0.5

Subtasks

Task #3529: Review 3527-infer-docker-hash-wipResolvedTom Clegg

Associated revisions

Revision eef298a7
Added by Brett Smith about 5 years ago

Merge branch '3527-infer-docker-hash-wip'

Closes #3527, #3529.

History

#1 Updated by Brett Smith about 5 years ago

  • Status changed from New to In Progress
  • Assigned To set to Brett Smith

#2 Updated by Tom Clegg about 5 years ago

  • Subject changed from Remove check for "docker_image_hash" link when job supplies a keep locator for "docker_image" . to [Crunch] Remove check for "docker_image_hash" link when job supplies a keep locator for "docker_image" .
  • Category set to Crunch

api/app/models/collection.rb requires dirname=='.' to recognize a docker image, but sdk/cli/bin/crunch-job doesn't require that. The sanity check should probably be the same in both places.

Other than that, this LGTM

#3 Updated by Brett Smith about 5 years ago

  • Category deleted (Crunch)

Tom Clegg wrote:

api/app/models/collection.rb requires dirname=='.' to recognize a docker image, but sdk/cli/bin/crunch-job doesn't require that. The sanity check should probably be the same in both places.

As discussed in IRC, crunch-job was assuming that the Docker image would be stored in the '.' stream. I taught it to accept any stream from the Collection, and removed the dirname check from the API server. Please take another look.

#4 Updated by Brett Smith about 5 years ago

  • Category set to Crunch

#5 Updated by Tom Clegg about 5 years ago

Ready!

#6 Updated by Brett Smith about 5 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100

Applied in changeset arvados|commit:eef298a7cf58771583b255fb0e3e1cfcbcdb6e48.

#7 Updated by Ward Vandewege about 5 years ago

  • Story points set to 0.5

Also available in: Atom PDF