Story #3620

[Workbench] Display system menu (gear menu) only to admin users.

Added by Radhika Chippada about 5 years ago. Updated about 5 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Radhika Chippada
Category:
-
Target version:
Start date:
08/25/2014
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
0.5

Subtasks

Task #3689: Review 3620-admin-only-gear-menuResolvedBrett Smith

Associated revisions

Revision 6e39e6e9
Added by Radhika Chippada about 5 years ago

closes #3620
Merge branch '3620-admin-only-gear-menu'

Revision b15e80cd
Added by Radhika Chippada about 5 years ago

refs #3620
Merge branch '3620-admin-only-gear-menu'

History

#1 Updated by Tom Clegg about 5 years ago

  • Story points set to 0.5

#2 Updated by Tom Clegg about 5 years ago

  • Target version set to Arvados Future Sprints

#3 Updated by Radhika Chippada about 5 years ago

  • Target version changed from Arvados Future Sprints to 2014-08-27 Sprint

#4 Updated by Radhika Chippada about 5 years ago

  • Status changed from New to In Progress
  • Assigned To set to Radhika Chippada

#5 Updated by Brett Smith about 5 years ago

Reviewing 3c12b61

I know this bug existed before your branch, but the diff made me notice it: list items that have useful content should not be marked with role="presentation". Otherwise, they may not render as desired in screen readers. Please migrate any list item with important text or links to role="menuitem". (See W3C's list of role definitions .)

The changes currently in the branch are good, so it should be able to merge with that. Thanks.

#6 Updated by Radhika Chippada about 5 years ago

  • Status changed from In Progress to Resolved

Applied in changeset arvados|commit:6e39e6e9ce10895a5405c90a0b61290ab507d16d.

Also available in: Atom PDF