Idea #3620
closed
[Workbench] Display system menu (gear menu) only to admin users.
Added by Radhika Chippada over 10 years ago.
Updated about 10 years ago.
Assigned To:
Radhika Chippada
- Target version set to Arvados Future Sprints
- Target version changed from Arvados Future Sprints to 2014-08-27 Sprint
- Status changed from New to In Progress
- Assigned To set to Radhika Chippada
Reviewing 3c12b61
I know this bug existed before your branch, but the diff made me notice it: list items that have useful content should not be marked with role="presentation"
. Otherwise, they may not render as desired in screen readers. Please migrate any list item with important text or links to role="menuitem"
. (See W3C's list of role definitions .)
The changes currently in the branch are good, so it should be able to merge with that. Thanks.
- Status changed from In Progress to Resolved
Applied in changeset arvados|commit:6e39e6e9ce10895a5405c90a0b61290ab507d16d.
Also available in: Atom
PDF