Bug #3637

[Workbench] Add "copy" operation to selection dropdown on projects#show tabs. Remove copy/move from clippy menu.

Added by Bryan Cosca over 6 years ago. Updated over 6 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Radhika Chippada
Category:
-
Target version:
2014-09-17 sprint
Start date:
08/20/2014
Due date:
% Done:

100%

Estimated time:
(Total: 3.00 h)
Story points:
1.0

Description

trying to move d0e8e7747e288e2778b25e70890e95cd+499 to project qr1hi-j7d0g-qhf708xb2s7cow2 didn't work.

Subtasks

Task #3790: Review branch: 3637-copy-selectionsResolvedTim Pierce

Task #3776: Pass selected items list through chooser to its actionResolvedTom Clegg

Task #3779: Review 3637-selection-through-chooserResolvedRadhika Chippada

Associated revisions

Revision 5b953c11
Added by Radhika Chippada over 6 years ago

refs #3637 - merge Tom's updates to chooser implementation, where selected items are passed as parameters.
Merge branch '3637-selection-through-chooser'

Revision 0fdafcb8
Added by Radhika Chippada over 6 years ago

closes #3637
Merge branch '3637-copy-selections'

History

#1 Updated by Tom Clegg over 6 years ago

  • Subject changed from Copy/Move selections from the paperclip doesn't work to [Workbench] Add "copy" operation to selection dropdown on projects#show tabs. Remove copy/move from clippy menu.
  • Story points set to 1.0

#2 Updated by Tom Clegg over 6 years ago

  • Target version set to Arvados Future Sprints

#3 Updated by Ward Vandewege over 6 years ago

  • Target version changed from Arvados Future Sprints to 2014-09-17 sprint

#4 Updated by Brett Smith over 6 years ago

  • Assigned To set to Brett Smith

#5 Updated by Brett Smith over 6 years ago

  • Assigned To deleted (Brett Smith)

#6 Updated by Radhika Chippada over 6 years ago

  • Assigned To set to Radhika Chippada

#7 Updated by Radhika Chippada over 6 years ago

  • Status changed from New to In Progress

#8 Updated by Radhika Chippada over 6 years ago

The "copy" operation in the project selection drop-down is applicable only to non-project type objects. Thus, sub-projects(s) from a project cannot be copied.

#9 Updated by Tim Pierce over 6 years ago

Reviewing at 44bcabe9:

Code looks good. Can we add a test to confirm that subprojects cannot be copied between projects?

#10 Updated by Radhika Chippada over 6 years ago

Tim, thanks for the feedback. I added one more test that checks the selection state on the copy action when a subproject is selected.

#11 Updated by Tim Pierce over 6 years ago

Radhika Chippada wrote:

Tim, thanks for the feedback. I added one more test that checks the selection state on the copy action when a subproject is selected.

LGTM. Thanks for adding this.

#12 Updated by Radhika Chippada over 6 years ago

  • Status changed from In Progress to Resolved

Applied in changeset arvados|commit:0fdafcb846ec6bb34e4b8ae91ad62c1ccd328355.

Also available in: Atom PDF