Bug #3704
closed[Workbench] Server-side search fails choosing pipeline inputs with search terms
Description
Part one (fixed): In current master Workbench, when I try to select inputs for a pipeline that has search terms for its inputs, the search fails. Workbench console shows the following—the filters parameter seems malformed.
Started GET "/collections/choose?partial=true&filters=%5B%5B%22owner_uuid%22%2C%22%3D%22%2C%224xphq-j7d0g-7qvnywohs3wbwi0%22%5D%5Dany%2Cilike%2C%25Tutorial+chromosome+19+reference%25" for ::1 at 2014-08-26 16:41:36 -0400 Processing by CollectionsController#choose as JSON Parameters: {"partial"=>"true", "filters"=>"[[\"owner_uuid\",\"=\",\"4xphq-j7d0g-7qvnywohs3wbwi0\"]]any,ilike,%Tutorial chromosome 19 reference%"}
Part two (open): After Tom's updates, the filters are well-formed again, but the steps to find a Collection from the tutorial project fail, because they search for a Collection with two different owner_uuids.
Started GET "/collections/choose?partial=true&filters=%5B%5B%22owner_uuid%22%2C%22%3D%22%2C%22qr1hi-j7d0g-keafgkrcj1uoexf%22%5D%2C%5B%22any%22%2C%22ilike%22%2C%22%25Tutorial+chromosome+19+reference%25%22%5D%2C%5B%22owner_uuid%22%2C%22%3D%22%2C%22qr1hi-j7d0g-u7zg1qdaowykd8d%22%5D%5D&project_uuid=qr1hi-j7d0g-u7zg1qdaowykd8d" for ::1 at 2014-09-02 09:16:54 -0400 Processing by CollectionsController#choose as JSON Parameters: {"partial"=>"true", "filters"=>"[[\"owner_uuid\",\"=\",\"qr1hi-j7d0g-keafgkrcj1uoexf\"],[\"any\",\"ilike\",\"%Tutorial chromosome 19 reference%\"],[\"owner_uuid\",\"=\",\"qr1hi-j7d0g-u7zg1qdaowykd8d\"]]", "project_uuid"=>"qr1hi-j7d0g-u7zg1qdaowykd8d"}
Updated by Tom Clegg over 10 years ago
- Target version changed from 2014-08-27 Sprint to 2014-09-17 sprint
Updated by Brett Smith over 10 years ago
- Assigned To deleted (
Tom Clegg)
Tom's branch improves the situation, but still doesn't restore the original search behavior. Now when I go through our tutorial steps to select an input for the tutorial GATK3 pipeline, when I select "Arvados Tutorial" from the project pulldown, this search happens:
Started GET "/collections/choose?partial=true&filters=%5B%5B%22owner_uuid%22%2C%22%3D%22%2C%22qr1hi-j7d0g-keafgkrcj1uoexf%22%5D%2C%5B%22any%22%2C%22ilike%22%2C%22%25Tutorial+chromosome+19+reference%25%22%5D%2C%5B%22owner_uuid%22%2C%22%3D%22%2C%22qr1hi-j7d0g-u7zg1qdaowykd8d%22%5D%5D&project_uuid=qr1hi-j7d0g-u7zg1qdaowykd8d" for ::1 at 2014-09-02 09:16:54 -0400 Processing by CollectionsController#choose as JSON Parameters: {"partial"=>"true", "filters"=>"[[\"owner_uuid\",\"=\",\"qr1hi-j7d0g-keafgkrcj1uoexf\"],[\"any\",\"ilike\",\"%Tutorial chromosome 19 reference%\"],[\"owner_uuid\",\"=\",\"qr1hi-j7d0g-u7zg1qdaowykd8d\"]]", "project_uuid"=>"qr1hi-j7d0g-u7zg1qdaowykd8d"}
The search succeeds, but returns no results, because it's looking for something with two different owner_uuids. I think the choose filters need to be made smarter about updating existing search filters rather than simply appending new ones.
Updated by Brett Smith over 10 years ago
- Status changed from In Progress to Resolved
- % Done changed from 50 to 100
Applied in changeset arvados|commit:812f2714c2908e5b427a8e37032ddcd46fb08297.