Bug #3714

[Workbench] small bugs in "report bug on the page" feature

Added by Ward Vandewege over 6 years ago. Updated over 6 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Radhika Chippada
Category:
-
Target version:
Start date:
08/27/2014
Due date:
% Done:

100%

Estimated time:
(Total: 3.00 h)
Story points:
0.5

Subtasks

Task #3716: submitting without contents in the "describe the problem" is possible, should not submit a bug and tell the user to put something in the boxResolved

Task #3715: workbench and api server version always render as 6333000Resolved

Task #3746: Review branch: 3714-report-issue-issuesResolvedRadhika Chippada

Associated revisions

Revision 21c6d252
Added by Radhika Chippada over 6 years ago

closes #3714
Merge branch '3714-report-issue-issues'

History

#1 Updated by Ward Vandewege over 6 years ago

  • Target version set to Arvados Future Sprints

#2 Updated by Ward Vandewege over 6 years ago

  • Target version changed from Arvados Future Sprints to 2014-09-17 sprint

#3 Updated by Ward Vandewege over 6 years ago

  • Story points set to 0.5

#4 Updated by Ward Vandewege over 6 years ago

  • Subject changed from small bugs in "report bug on the page" feature to [Workbench] small bugs in "report bug on the page" feature

#5 Updated by Radhika Chippada over 6 years ago

  • Assigned To set to Radhika Chippada

#6 Updated by Radhika Chippada over 6 years ago

  • Status changed from New to In Progress

#7 Updated by Brett Smith over 6 years ago

Reviewing 0313947

  • It feels a little unfortunate that the disable code is duplicated, once in the JavaScript's main body and a second time in the input change event. Would it be possible to define a function, call it immediately, and then bind it to the event?
  • I'm not sure I understand the purpose of the trigger boolean. Would it be simpler to just write the desired actions directly in if and else clauses?
  • My understanding is that it's JavaScript best practice to use the === operator instead of == for most comparisons against specific values. This page illustrates the issues with ==.
  • In report_issue_test.rb, the button assertion before sending the report is not indented consistently.

Thanks.

#8 Updated by Brett Smith over 6 years ago

c96deb5 looks good to me. Thank you!

#9 Updated by Radhika Chippada over 6 years ago

  • Status changed from In Progress to Resolved

Applied in changeset arvados|commit:21c6d252b279c9714419bf65da07e32246572238.

Also available in: Atom PDF