https://dev.arvados.org/https://dev.arvados.org/favicon.ico?15576888422014-08-27T13:09:52ZArvadosArvados - Bug #3714: [Workbench] small bugs in "report bug on the page" featurehttps://dev.arvados.org/issues/3714?journal_id=141692014-08-27T13:09:52ZWard Vandewegeward@curii.com
<ul><li><strong>Target version</strong> set to <i>Arvados Future Sprints</i></li></ul> Arvados - Bug #3714: [Workbench] small bugs in "report bug on the page" featurehttps://dev.arvados.org/issues/3714?journal_id=141882014-08-27T14:06:41ZWard Vandewegeward@curii.com
<ul><li><strong>Target version</strong> changed from <i>Arvados Future Sprints</i> to <i>2014-09-17 sprint</i></li></ul> Arvados - Bug #3714: [Workbench] small bugs in "report bug on the page" featurehttps://dev.arvados.org/issues/3714?journal_id=142512014-08-27T15:16:49ZWard Vandewegeward@curii.com
<ul><li><strong>Story points</strong> set to <i>0.5</i></li></ul> Arvados - Bug #3714: [Workbench] small bugs in "report bug on the page" featurehttps://dev.arvados.org/issues/3714?journal_id=142542014-08-27T15:17:20ZWard Vandewegeward@curii.com
<ul><li><strong>Subject</strong> changed from <i>small bugs in "report bug on the page" feature</i> to <i>[Workbench] small bugs in "report bug on the page" feature</i></li></ul> Arvados - Bug #3714: [Workbench] small bugs in "report bug on the page" featurehttps://dev.arvados.org/issues/3714?journal_id=142702014-08-27T15:24:26ZRadhika Chippadaradhika@curoverse.com
<ul><li><strong>Assigned To</strong> set to <i>Radhika Chippada</i></li></ul> Arvados - Bug #3714: [Workbench] small bugs in "report bug on the page" featurehttps://dev.arvados.org/issues/3714?journal_id=143132014-08-27T16:53:27ZRadhika Chippadaradhika@curoverse.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li></ul> Arvados - Bug #3714: [Workbench] small bugs in "report bug on the page" featurehttps://dev.arvados.org/issues/3714?journal_id=143632014-08-28T14:03:04ZBrett Smithbrett.smith@curii.com
<ul></ul><p>Reviewing <a class="changeset" title="3714: update tests to verify that the send report button is disabled until problem description is..." href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/0313947c4cb1ece72d808d35a76e0751080ee083">0313947</a></p>
<ul>
<li>It feels a little unfortunate that the disable code is duplicated, once in the JavaScript's main body and a second time in the input change event. Would it be possible to define a function, call it immediately, and then bind it to the event?</li>
<li>I'm not sure I understand the purpose of the <code>trigger</code> boolean. Would it be simpler to just write the desired actions directly in <code>if</code> and <code>else</code> clauses?</li>
<li>My understanding is that it's JavaScript best practice to use the <code>===</code> operator instead of <code>==</code> for most comparisons against specific values. <a href="http://dorey.github.io/JavaScript-Equality-Table/" class="external">This page illustrates the issues with <code>==</code></a>.</li>
<li>In <code>report_issue_test.rb</code>, the button assertion before sending the report is not indented consistently.</li>
</ul>
<p>Thanks.</p> Arvados - Bug #3714: [Workbench] small bugs in "report bug on the page" featurehttps://dev.arvados.org/issues/3714?journal_id=143862014-08-28T16:17:54ZBrett Smithbrett.smith@curii.com
<ul></ul><p><a class="changeset" title="3714: minor updates from review feedback" href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/c96deb58149e6b31efd13d45170dc7f70a6109ea">c96deb5</a> looks good to me. Thank you!</p> Arvados - Bug #3714: [Workbench] small bugs in "report bug on the page" featurehttps://dev.arvados.org/issues/3714?journal_id=143902014-08-28T16:30:09ZRadhika Chippadaradhika@curoverse.com
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Resolved</i></li></ul><p>Applied in changeset arvados|commit:21c6d252b279c9714419bf65da07e32246572238.</p>