https://dev.arvados.org/https://dev.arvados.org/favicon.ico?15576888422014-08-28T18:10:23ZArvadosArvados - Idea #3762: [Keep] Process entries on the current "delete" list.https://dev.arvados.org/issues/3762?journal_id=143942014-08-28T18:10:23ZTom Cleggtom@curii.com
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/14394/diff?detail_id=13106">diff</a>)</li><li><strong>Category</strong> set to <i>Keep</i></li></ul> Arvados - Idea #3762: [Keep] Process entries on the current "delete" list.https://dev.arvados.org/issues/3762?journal_id=207752015-01-30T18:53:37ZTom Cleggtom@curii.com
<ul><li><strong>Target version</strong> changed from <i>Arvados Future Sprints</i> to <i>2015-03-11 sprint</i></li></ul> Arvados - Idea #3762: [Keep] Process entries on the current "delete" list.https://dev.arvados.org/issues/3762?journal_id=211582015-02-13T19:11:38ZTom Cleggtom@curii.com
<ul><li><strong>Target version</strong> changed from <i>2015-03-11 sprint</i> to <i>Arvados Future Sprints</i></li></ul> Arvados - Idea #3762: [Keep] Process entries on the current "delete" list.https://dev.arvados.org/issues/3762?journal_id=222582015-03-11T19:28:48ZTom Cleggtom@curii.com
<ul><li><strong>Target version</strong> changed from <i>Arvados Future Sprints</i> to <i>2015-04-01 sprint</i></li></ul> Arvados - Idea #3762: [Keep] Process entries on the current "delete" list.https://dev.arvados.org/issues/3762?journal_id=222592015-03-11T19:29:53ZRadhika Chippadaradhika@curoverse.com
<ul><li><strong>Assigned To</strong> set to <i>Radhika Chippada</i></li></ul> Arvados - Idea #3762: [Keep] Process entries on the current "delete" list.https://dev.arvados.org/issues/3762?journal_id=223722015-03-13T20:15:57ZTom Cleggtom@curii.com
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/22372/diff?detail_id=21562">diff</a>)</li></ul> Arvados - Idea #3762: [Keep] Process entries on the current "delete" list.https://dev.arvados.org/issues/3762?journal_id=225212015-03-20T15:30:36ZRadhika Chippadaradhika@curoverse.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li></ul> Arvados - Idea #3762: [Keep] Process entries on the current "delete" list.https://dev.arvados.org/issues/3762?journal_id=226172015-03-23T14:17:34ZPeter Amstutzpeter.amstutz@curii.com
<ul></ul><p>Reviewing 3762-delete-list-worker <a class="changeset" title="Merge branch 'master' into 3762-delete-list-worker" href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/fed6d3b24a6c49df01601dfdc27182fd0770b013">fed6d3b</a></p>
<p>The cached discovery document should part of the ArvadosClient struct, not the <code>DISCOVERY</code> global variable. You should probably fetch the discovery document in MakeArvadosClient().</p>
<p>If you want to return "any type" in Go, you use <code>interface{}</code>. Then <code>Discovery()</code> does not need to create valueMap just to return as single item.</p>
<p>I just realized that having the trashWorker fetch "defaultTrashLifetime" from the discovery document means that we are re-introducing a dependency on the API server that we had just worked to eliminate with the pullWorker. We should consult tom/ward on their preference.</p>
<p>I noticed this in both pullq and trashq:<br /><pre>
if pullq == nil {
pullq = NewWorkQueue()
}
</pre></p>
<p><code>trashq</code> and <code>pullq</code> should <em>never</em> be nil, and if they are nil, allocating a new work queue won't do anything because there won't be a worker goroutine associated with it. These tests should be taken out or converted into a assertions that raise an error.</p> Arvados - Idea #3762: [Keep] Process entries on the current "delete" list.https://dev.arvados.org/issues/3762?journal_id=226202015-03-23T15:06:47ZTom Cleggtom@curii.com
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/22620/diff?detail_id=21826">diff</a>)</li></ul> Arvados - Idea #3762: [Keep] Process entries on the current "delete" list.https://dev.arvados.org/issues/3762?journal_id=226282015-03-23T16:20:59ZRadhika Chippadaradhika@curoverse.com
<ul></ul><ul>
<li>Removed all the new code for API discovery and instead using permission_ttl. Per our discussion with Tom, defaultTrashLifetime is the same as permission_ttl, which is already available in keepstore and this should be used.</li>
</ul>
<ul>
<li>Removed "if pullq == nil ... " from handlers.go and updated the handler_test instead to create the instances of pullq and trashq.</li>
</ul> Arvados - Idea #3762: [Keep] Process entries on the current "delete" list.https://dev.arvados.org/issues/3762?journal_id=227212015-03-25T15:53:53ZPeter Amstutzpeter.amstutz@curii.com
<ul></ul><p>LGTM</p> Arvados - Idea #3762: [Keep] Process entries on the current "delete" list.https://dev.arvados.org/issues/3762?journal_id=227342015-03-25T17:30:09ZRadhika Chippadaradhika@curoverse.com
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Resolved</i></li><li><strong>% Done</strong> changed from <i>50</i> to <i>100</i></li></ul><p>Applied in changeset arvados|commit:0d1971f04c8f0674ff8d94bae5dbb7f6b94e7f5f.</p>