Bug #3785

[Crunch] Job log collections should be stored with the same owner_uuid (and therefore permissions) as the job

Added by Brett Smith over 6 years ago. Updated about 6 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Crunch
Target version:
Start date:
09/02/2014
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
0.5

Description

A user has permission to see a Job through a Project. They can visit the Job page just fine. However, they do not have permission to read the Job's log. Crunch should arrange for logs to be readable by anyone with read permission to the owning Project.

This won't address the related problem that log/output (and their permissions) stay in project A when the relevant job/pipeline moves from project A to project B.


Subtasks

Task #5271: Fix crunch-jobResolvedPeter Amstutz

Task #5295: Review 3785-job-log-collection-ownerResolvedRadhika Chippada

Associated revisions

Revision 18ddae75
Added by Peter Amstutz about 6 years ago

Merge branch '3785-job-log-collection-owner' closes #3785

History

#1 Updated by Ward Vandewege over 6 years ago

  • Target version set to Arvados Future Sprints

#2 Updated by Tom Clegg about 6 years ago

  • Subject changed from [Crunch] Project Pipeline Job Logs should be readable by Project participants to [Crunch] Job log collections should be stored with the same owner_uuid (and therefore permissions) as the job
  • Description updated (diff)
  • Target version changed from Arvados Future Sprints to 2015-03-11 sprint

#3 Updated by Ward Vandewege about 6 years ago

  • Story points set to 0.5

#4 Updated by Peter Amstutz about 6 years ago

  • Assigned To set to Peter Amstutz

#5 Updated by Radhika Chippada about 6 years ago

Peter,
The update to set the owner_uuid for the log itself looks good.

Just a couple of questions.

  • Is it possible to test this update?
  • Now that we are setting the owner_uuid of the job log correctly, it is desirable that we no longer "hide" the Log tab for anonymous users. Would you update workbench/app/controllers/jobs_controller -> show_pane_list accordingly? There might a couple tests that need to be updated as well.

Thanks.

#6 Updated by Peter Amstutz about 6 years ago

Radhika Chippada wrote:

Peter,
The update to set the owner_uuid for the log itself looks good.

Just a couple of questions.

  • Is it possible to test this update?

As has been often discussed, unfortunately we don't have a testing framework for crunch-job, so there is no way to easily add an automated test.

  • Now that we are setting the owner_uuid of the job log correctly, it is desirable that we no longer "hide" the Log tab for anonymous users. Would you update workbench/app/controllers/jobs_controller -> show_pane_list accordingly? There might a couple tests that need to be updated as well.

Fixed show_pane_list. Ran all the workbench tests, no failures.

Thanks.

#7 Updated by Radhika Chippada about 6 years ago

Peter, I understand about the testing crunch jobs. LGTM

#8 Updated by Peter Amstutz about 6 years ago

  • Status changed from New to Resolved

Applied in changeset arvados|commit:18ddae75beb91b0792ad34a9b4996316715e67b7.

Also available in: Atom PDF