Bug #3866

[SDK] Python KeepClient needs to construct URLs smarter

Added by Brett Smith almost 5 years ago. Updated almost 5 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Brett Smith
Category:
SDKs
Target version:
Start date:
09/15/2014
Due date:
% Done:

100%

Estimated time:
Story points:
0.5

Description

When the Python KeepClient makes a request to a Keep service, it constructs the Keep service URL with simple string concatenation. This can lead to malformed URLs; e.g., if the service host is an IPv6 address, you'll get a URL like http://100:::8000/.... We should use a smarter method like urljoin.

Associated revisions

Revision b3fd3679 (diff)
Added by Brett Smith almost 5 years ago

3866: PySDK KeepClient accommodates services with IPv6 addresses.

I thought there was going to be a nicer way to construct URLs than
this, but urllib.urlunparse is still expecting the host+port as a
single string, so this approach is easier. Closes #3866.

History

#1 Updated by Brett Smith almost 5 years ago

  • Target version set to Bug Triage

#2 Updated by Tom Clegg almost 5 years ago

  • Target version changed from Bug Triage to 2014-10-08 sprint

#3 Updated by Brett Smith almost 5 years ago

  • Assigned To set to Brett Smith

#4 Updated by Brett Smith almost 5 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100

Applied in changeset arvados|commit:b3fd3679187be8e51d31cb6bf17613cc488cda4b.

Also available in: Atom PDF