Feature #3900
closed
[Workbench] Trash button on collection uses "delete" API instead of setting expires_at/trash_at
Added by Tom Clegg over 10 years ago.
Updated almost 8 years ago.
Description
The trash button for collections in Workbench should use the collections/delete API instead of changing owner_uuid to current_user.uuid (aka "home project"). The collection will then be wiped from the current listing, as the trash button does now, because trashed collections do not appear in collection listings.
See Expiring collections
- Subject changed from [Workbench] Trash button on collection sets expiry time to now+trash_ttl (see #3411), trashed collections are hidden unless "show trashed collections" checkbox is checked to [Workbench] Trash button on collection sets expires_at
- Description updated (diff)
- Assigned To set to Brett Smith
- Story points deleted (
2.5)
- Description updated (diff)
- Description updated (diff)
- Assigned To changed from Brett Smith to Tom Morris
- Assigned To deleted (
Tom Morris)
- Description updated (diff)
- Description updated (diff)
- Target version changed from Arvados Future Sprints to 2017-02-15 sprint
- Story points set to 1.0
- Assigned To set to Lucas Di Pentima
- Status changed from New to In Progress
- Subject changed from [Workbench] Trash button on collection sets expires_at to [Workbench] Trash button on collection uses "delete" API instead of setting expires_at/trash_at
Branch 3900-trash-collections-delete-api at 108467e
Test run: https://ci.curoverse.com/job/developer-run-tests/158/
Changed projects controller to call destroy method on every item removed. When removing a collection, also reparent it to the home project so that the project can be eventually deleted.
Updates: 4dbaf8c
Test run: https://ci.curoverse.com/job/developer-run-tests/159/
Reverted changes so that Workbench make a delete API call on collection removal only, as there are explicit functional tests that check for other objects inside projects to be moved to the Home project when removed.
Although TomC said to me that WB should ask for API delete method on any object being removed from a project regardless its type, the fact that there are tests confirming that non-collection objects should be moved instead of deleted make me think this is out of scope for this ticket and not a simple change.
- Status changed from In Progress to Resolved
- % Done changed from 0 to 100
Applied in changeset arvados|commit:d3719c6ba29daec66eb1dd4003f2580f97da8e41.
Also available in: Atom
PDF
Updated by 
Updated by 
Updated by Tom Morris 
Updated by 
Updated by Radhika Chippada