Arvados

Review comments:

• These new buttons are quite helpful.

• If felt a little weird to see "All jobs" button in the panel with header "Compute status". It feels like it should point to "Compute nodes" page. May be we might want to improve the panel title to "Compute and job status" or something like that?

• This update can absolutely use an integration test. A test that executes the following steps:
  • visit dashboard
  • click on "Run a pipeline..." button and verify that able to create a pipeline or at least initiate creation of pipeline
  • click on each of the 3 "All xxx..." buttons and verify that we end up in that respective page and look for one of the items listed in the fixtures

• I also noticed from the workbench console log the following: It seems that the dashboard is being reloaded every few (15?) seconds. In the console log, I saw multiple requests being made to the API server (see blow). I am concerned about performance impact when we have several users using the system? Do you think you can get all data (at least for each type) in one request?

API client: 0.000447701 Parse response
Rendered application/_pipeline_status_label.html.erb (0.2ms)
API client: 0.000512425 Prepare request https://localhost:3030/arvados/v1/pipeline_templates {"uuid":"zzzzz-p5p6p-rxj8d71854j9idn"}
API client: 0.050315221 API transaction
API client: 0.041700684 request_time
API client: 0.000296891 Parse response
Rendered application/_pipeline_status_label.html.erb (0.1ms)
API client: 0.000244403 Prepare request https://localhost:3030/arvados/v1/pipeline_templates {"uuid":"zzzzz-p5p6p-rxj8d71854j9idn"}
API client: 0.054005062 API transaction
API client: 0.046160175 request_time
API client: 0.00074173 Parse response
Rendered application/_pipeline_status_label.html.erb (0.2ms)
API client: 0.000304222 Prepare request https://localhost:3030/arvados/v1/pipeline_templates {"uuid":"zzzzz-p5p6p-rxj8d71854j9idn"}
. . .

Radhika Chippada wrote:

Review comments:

• These new buttons are quite helpful.

• If felt a little weird to see "All jobs" button in the panel with header "Compute status". It feels like it should point to "Compute nodes" page. May be we might want to improve the panel title to "Compute and job status" or something like that?

Fixed.

• This update can absolutely use an integration test. A test that executes the following steps:
  • visit dashboard
  • click on "Run a pipeline..." button and verify that able to create a pipeline or at least initiate creation of pipeline
  • click on each of the 3 "All xxx..." buttons and verify that we end up in that respective page and look for one of the items listed in the fixtures

Done.

• I also noticed from the workbench console log the following: It seems that the dashboard is being reloaded every few (15?) seconds. In the console log, I saw multiple requests being made to the API server (see blow). I am concerned about performance impact when we have several users using the system? Do you think you can get all data (at least for each type) in one request?

Batched up requests for pipeline templates and disabled requests for collection tags. Improves dashboard rendering time by at least 25%

Peter: thanks for update. It is much better now.

Sorry for being a strickler, but I just have one request about the test 'Run a pipeline from dashboard' in "apps/workbench/test/integration/pipeline_instances_test.rb". Please move the code that does "#create a pipeline instance" etc into a reusable method in this test class and reuse from both the tests. Thanks.

LGTM otherwise.