Tapestry

Looking at f669bfb

I see changes to routes.rb and schema.rb, but I don't see a new controller or views or a migration. Am I looking at the wrong commit, or did some files get left out, or...?

Doh, indeed, missing. Now checked in as 1616b6e

•      <strong><%= @user.full_name -%></strong>
  -  <% else -%>
  -    <% if logged_in? and  @user == current_user %>
  +  <% elsif logged_in? and @user == current_user %>
  +    <h3>
  +      Real Name
         <%= link_to "[Add real name]", add_real_name_path -%>
  -    <% end -%>
  +    </h3>
     <% end -%>
  

I think it would be good to use get instead of match in config/routes.rb since we don't intend to respond to any post/put/patch/... requests here. (Also, one less thing to do for rails4, which doesn't like "any method" routes.)

app/views/admin/researchers/third_party.html.erb is new in this branch. Is that intentional? (Maybe an unrelated bugfix?)

The rest of my comments are just language bikesheds. I don't think any of them should prevent merging, or override any discussion that's already happened elsewhere.

• Existing: others may have created copies of your data outside the PGP.
• Suggestion: researchers and search engines will have already downloaded and stored copies of it, and this cannot be reversed.
• Extreme suggestion: the link between your name, your participant ID, and your other public data -- like all other information appearing on public web sites -- will have been downloaded and archived by researchers, search engines, health providers, insurers, and government agencies. It will be impossible to know who has kept a copy.

• Existing: The PGP is "non-anonymous", anonymity cannot be guaranteed.
• Suggestion: Participation in the PGP should never be considered anonymous or private.

• Existing: You've asked to remove your real name from your public profile.
• Suggestion: You are about to remove your real name from your public profile.