Bug #4058

[Workbench] "Show portable data hash" page should show the kind of content that relates to PDH instead of trying to be a mostly-functional "show collection" page.

Added by Ward Vandewege about 5 years ago. Updated about 5 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Target version:
Start date:
10/20/2014
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
1.0

Description

If you search for a manifest hash in workbench, you land on a page that pretends to be a collection page but is not.

It has all sorts of misleading features, like a 'copy to project' button that doesn't work.

This needs to be changed.

If there is only one collection that points to this manifest hash, workbench should redirect there instead. If there are multiple, it should have a page that clearly indicates that and lets the user choose one to view.


Subtasks

Task #4263: Review 4058-workbench-collection-redirectResolvedPeter Amstutz

Task #4149: Redirect when there is a single collection, show a "menu" page when there is more than one collectionResolvedPeter Amstutz

Task #4150: Add testsResolvedPeter Amstutz


Related issues

Has duplicate Arvados - Bug #4032: [Workbench] No provenance when querying collection by portable_data_hashRejected

Associated revisions

Revision 11085f87
Added by Peter Amstutz about 5 years ago

Merge branch '4058-workbench-collection-redirect' closes #4058

Revision 2def2025 (diff)
Added by Peter Amstutz about 5 years ago

Increase limit for collections controller querying same portable_data_hash as
workaround to fix tests, refs #4058, but really needs a proper fix, refs #3400

History

#1 Updated by Ward Vandewege about 5 years ago

  • Description updated (diff)

#2 Updated by Tom Clegg about 5 years ago

  • Subject changed from [Workbench] Remove the abomination that is the fake collection page to [Workbench] "Show portable data hash" page should show the kind of content that relates to PDH instead of trying to be a mostly-functional "show collection" page.
  • Story points set to 1.0

#3 Updated by Tom Clegg about 5 years ago

  • Target version changed from Bug Triage to Arvados Future Sprints

#4 Updated by Ward Vandewege about 5 years ago

  • Target version changed from Arvados Future Sprints to 2014-10-29 sprint

#5 Updated by Peter Amstutz about 5 years ago

  • Assigned To set to Peter Amstutz

#6 Updated by Brett Smith about 5 years ago

Reviewing d599adb

The code is good. A couple of things about the view. First, there's a typo: "collections" should be plural in "The following collection have this content." Second, the page uses an h1, which we don't use on any main Workbench interface pages—just error pages, which makes it look a little jarring. I think it'd be nice to have the presentation a little more consistent with the rest of Workbench. Like, as one idea I had, just have the row with:

      <div class="panel-heading">
        <h3 class="panel-title"><%= params["uuid"] %></h3>
      </div>
      <div class="panel-body">
        <i>The following collections have this content:</i>

But that's just something I spitballed. I'd be happy with anything that follows Workbench conventions a little more closely. Thanks.

#7 Updated by Peter Amstutz about 5 years ago

Brett Smith wrote:

Reviewing d599adb

The code is good. A couple of things about the view. First, there's a typo: "collections" should be plural in "The following collection have this content." Second, the page uses an h1, which we don't use on any main Workbench interface pages—just error pages, which makes it look a little jarring. I think it'd be nice to have the presentation a little more consistent with the rest of Workbench. Like, as one idea I had, just have the row with:

[...]

But that's just something I spitballed. I'd be happy with anything that follows Workbench conventions a little more closely. Thanks.

Done.

#8 Updated by Brett Smith about 5 years ago

Peter Amstutz wrote:

Done.

81cb0b6a still says "collection have." Make "collections" plural and this is good to merge, thanks.

#9 Updated by Anonymous about 5 years ago

  • Status changed from New to Resolved
  • % Done changed from 67 to 100

Applied in changeset arvados|commit:11085f87c952c7e46a15c88e144190cac32b95a8.

Also available in: Atom PDF