Bug #4058
closed
[Workbench] "Show portable data hash" page should show the kind of content that relates to PDH instead of trying to be a mostly-functional "show collection" page.
Description
If you search for a manifest hash in workbench, you land on a page that pretends to be a collection page but is not.
It has all sorts of misleading features, like a 'copy to project' button that doesn't work.
This needs to be changed.
If there is only one collection that points to this manifest hash, workbench should redirect there instead. If there are multiple, it should have a page that clearly indicates that and lets the user choose one to view.
Updated by Tom Clegg about 10 years ago
- Subject changed from [Workbench] Remove the abomination that is the fake collection page to [Workbench] "Show portable data hash" page should show the kind of content that relates to PDH instead of trying to be a mostly-functional "show collection" page.
- Story points set to 1.0
Updated by Tom Clegg about 10 years ago
- Target version changed from Bug Triage to Arvados Future Sprints
Updated by Ward Vandewege about 10 years ago
- Target version changed from Arvados Future Sprints to 2014-10-29 sprint
Updated by Brett Smith about 10 years ago
Reviewing d599adb
The code is good. A couple of things about the view. First, there's a typo: "collections" should be plural in "The following collection have this content." Second, the page uses an h1, which we don't use on any main Workbench interface pages—just error pages, which makes it look a little jarring. I think it'd be nice to have the presentation a little more consistent with the rest of Workbench. Like, as one idea I had, just have the row with:
<div class="panel-heading">
<h3 class="panel-title"><%= params["uuid"] %></h3>
</div>
<div class="panel-body">
<i>The following collections have this content:</i>
…
But that's just something I spitballed. I'd be happy with anything that follows Workbench conventions a little more closely. Thanks.
Updated by Peter Amstutz about 10 years ago
Brett Smith wrote:
Reviewing d599adb
The code is good. A couple of things about the view. First, there's a typo: "collections" should be plural in "The following collection have this content." Second, the page uses an h1, which we don't use on any main Workbench interface pages—just error pages, which makes it look a little jarring. I think it'd be nice to have the presentation a little more consistent with the rest of Workbench. Like, as one idea I had, just have the row with:
[...]
But that's just something I spitballed. I'd be happy with anything that follows Workbench conventions a little more closely. Thanks.
Done.
Updated by Brett Smith about 10 years ago
Peter Amstutz wrote:
Done.
81cb0b6a still says "collection have." Make "collections" plural and this is good to merge, thanks.
Updated by Anonymous about 10 years ago
- Status changed from New to Resolved
- % Done changed from 67 to 100
Applied in changeset arvados|commit:11085f87c952c7e46a15c88e144190cac32b95a8.