[Workbench] Pipeline elapsed time is misformatted
In pipeline_instances/qr1hi-d1hrv-43y08obrh2vetuv, it says This pipeline started at 11:56 AM 10/16/2014. It failed after 4 minutes 52 seconds at 12:01 AM 10/16/2014.
I expected it to say 12:01 "PM"
refs #4227 - rescue from any error in parsing pipeline start and finish time so that jenkins runs do not choke on these failures.
refs #4227 - update strptime format for parsing pipeline start and finish time.
#4 Updated by Brett Smith over 6 years ago
Reviewing e102efba. The fix is good, but I'm surprised at how involved the test code is.
- I'm not sure I understand what value we get out of testing ten cases of this. It seems like we get the most value just by testing a simple case, a case that spans the AM/PM boundary, and a case that spans the midnight boundary. If there are other cases that have some unique property, then let's definitely include those. But ten seems like an arbitrary number, and that's a lot of overhead given that we're firing up a whole browser session to test datetime formatting.
- I now limited to two tests, one with 0 run time and one with run time that spans between AM and PM
- You can use DateTime::strptime to parse these strings, rather than doing all the splitting and array indexing yourself.
- Thanks for this tip. It is fantastic
- Rather than trying to parse the "elapsed time" string, let's use fixtures whose elapsed time we know ahead of time, and compare against that. That will save us a bunch of parsing and math that aren't directly relevant to what we're trying to test (the datetime formatting).
- Adjusted this
BTW, there's also trailing whitespace on some of the lines in the current branch.