Bug #4285
closed
[Workbench] Not found error when the view or download icons are clicked for a file in a subdir of a collection.
Related issues
Updated by Radhika Chippada over 9 years ago
Observed this issue while testing 4228:
Not only are we getting empty collections when combining files that are in a directory or sub-directory in a collection; we are getting "Not found" errors when such a file is downloaded or viewed.
This can be found in https://workbench.qr1hi.arvadosapi.com/collections/qr1hi-4zz18-w74zrwyvft9q81n
Another such collection: https://workbench.qr1hi.arvadosapi.com/collections/qr1hi-4zz18-74ikz4mn29q3i34
Updated by Tom Clegg over 9 years ago
- Status changed from New to In Progress
- Story points set to 0.5
Updated by Radhika Chippada over 9 years ago
- Assigned To set to Radhika Chippada
- Target version changed from Bug Triage to 2014-10-29 sprint
Updated by Brett Smith over 9 years ago
Reviewing f1eb092
I suggest writing the main fix as
file_name = params[:file].andand.sub(/^(\.\/|\/|)/, './')
This version avoids prepending ./ if it's already specified, and writes ./ correctly if params[:file] starts with a /. It does add ./ for the single-file case, but that's okay according to the Keep manifest documentation.
If you're comfortable with this change, I'm happy to see it merged. Thanks.
Updated by Radhika Chippada over 9 years ago
Thanks Brett. I updated accordingly.
Updated by Radhika Chippada over 9 years ago
- Status changed from In Progress to Resolved
Applied in changeset arvados|commit:a3db87c5a23f3a1e72ea82304d24db8c1757c095.