Bug #4358

[Tests] When comparing pipelines, the graph should highlight the differences by using different colors for pipeline A/B/both.

Added by Jonathan Sheffi over 4 years ago. Updated about 4 years ago.

Status:
New
Priority:
Normal
Assigned To:
-
Category:
Tests
Target version:
Start date:
10/29/2014
Due date:
% Done:

67%

Estimated time:
(Total: 1.00 h)
Story points:
0.5


Subtasks

Task #4816: Review 4358ResolvedPhil Hodgson

Task #4815: Make it highlight the differences once againResolvedPhil Hodgson

Task #4874: Test that comparisons display correctlyNew


Related issues

Related to Arvados - Feature #4088: [Workbench] On collections#show page, filter displayed files by filename regexp, and add a "select all" / "deselect all" button.Resolved2014-10-28

Associated revisions

Revision bfc23513
Added by Phil Hodgson over 4 years ago

Merge branch '4858-graph-not-comparing' refs #4358

History

#1 Updated by Brett Smith over 4 years ago

  • Subject changed from Compare pipeline instances looks wrong to [Workbench] Compare pipeline instances looks wrong
  • Category set to Workbench
  • Target version set to Bug Triage

#4088 might resolve this when it gets merged soon. Let's double-check after that and see if there are any outstanding issues.

#2 Updated by Brett Smith over 4 years ago

Jonathan,

The fix for #4088 is deployed, which I hope will resolve your issues. Can you please compare a couple of pipelines and see if you believe there are any outstanding issues?

Thanks.

#3 Updated by Jonathan Sheffi over 4 years ago

Mmm, the link I provided in the bug is definitely prettier, but doesn't seem to actually be comparing... Can Bryan test?

https://workbench.qr1hi.arvadosapi.com/pipeline_instances/compare?uuids%5B%5D=qr1hi-d1hrv-pep5f13gwh50paf&uuids%5B%5D=qr1hi-d1hrv-f651o1m7hmxv1ci#Graph

#4 Updated by Tom Clegg over 4 years ago

I think the problem being reported is that you can't tell which jobs/outputs are part of pipeline A and which are part of pipeline B: every node in the graph is green.

#5 Updated by Tom Clegg over 4 years ago

  • Subject changed from [Workbench] Compare pipeline instances looks wrong to [Workbench] When comparing pipelines, the graph should highlight the differences by using different colors for pipeline A/B/both.
  • Story points set to 1.0

#6 Updated by Tom Clegg over 4 years ago

  • Target version changed from Bug Triage to Arvados Future Sprints

#7 Updated by Ward Vandewege over 4 years ago

  • Target version changed from Arvados Future Sprints to 2014-12-10 sprint

#8 Updated by Ward Vandewege over 4 years ago

  • Assigned To set to Phil Hodgson

#9 Updated by Tom Clegg over 4 years ago

  • Target version changed from 2014-12-10 sprint to 2015-01-07 sprint

#10 Updated by Phil Hodgson over 4 years ago

Comments from Tom:

Basically you run a pipeline, then you run it again with some
parameter changed, and you see whether that actually changed your
outputs. Or: you don't remember which parameter/input you changed, so
you compare the two pipelines and it's obvious from the graph where
the two versions start to diverge.

https://workbench.qr1hi.arvadosapi.com/pipeline_instances/compare?uuids%5B%5D=qr1hi-d1hrv-z5hd2sylqsc9e9k&uuids%5B%5D=qr1hi-d1hrv-3wr2iqiq9xgs9cr#Graph

On the "compare" tab you can see the verifyBamID component is
different in some way. This should be apparent on the graph as well:
there should be two distinct graph nodes representing verifyBamID
jobs, and they should be coloured differently than the rest of the job
nodes (all of which are equivalent in the two pipelines).

(This used to work -- there was a legend "pipeline A, pipeline B,
both" -- but currently it looks like it's been lost completely.)

#11 Updated by Tom Clegg over 4 years ago

4358-graph-not-comparing @ 84b8801 looks good. Example in note-3 renders properly for me. Please merge.

I think we should add a test case before closing the issue, though. (Can we search the SVG graph with the usual Capybara finders, or is this going to get complicated on us?)

#12 Updated by Phil Hodgson over 4 years ago

Okay I've merged to master and added a new task for that test...

#13 Updated by Tom Clegg over 4 years ago

  • Status changed from New to In Progress

#14 Updated by Tom Clegg over 4 years ago

  • Subject changed from [Workbench] When comparing pipelines, the graph should highlight the differences by using different colors for pipeline A/B/both. to [Tests] When comparing pipelines, the graph should highlight the differences by using different colors for pipeline A/B/both.
  • Category changed from Workbench to Tests
  • Status changed from In Progress to New
  • Assigned To deleted (Phil Hodgson)

#15 Updated by Tom Clegg over 4 years ago

  • Target version changed from 2015-01-07 sprint to Arvados Future Sprints

#16 Updated by Tom Clegg over 4 years ago

  • Story points changed from 1.0 to 0.5

#17 Updated by Tom Clegg over 4 years ago

  • Target version changed from Arvados Future Sprints to 2015-02-18 sprint

#18 Updated by Tom Clegg about 4 years ago

  • Target version changed from 2015-02-18 sprint to Arvados Future Sprints

Also available in: Atom PDF