Bug #4388: [SDKs] Manifest#each_line should not crash when encountering a blank line in a manifest. - Arvados

Actions

Copy link

Bug #4388

closed

[SDKs] Manifest#each_line should not crash when encountering a blank line in a manifest.

Added by Tom Clegg over 9 years ago. Updated over 9 years ago.

Status:

Resolved

Priority:

Normal

Assigned To:

Brett Smith

Category:

SDKs

Target version:

2014-11-19 sprint

Story points:

0.5

Description

While displaying the collections tab on "show Home project":

Started GET "/projects/qr1hi-tpzed-tpj2ff66551eyym?partial=contents_rows&filters=%5B%5B%22uuid%22%2C%22is_a%22%2C%22arvados%23collec
tion%22%5D%5D" for 192.168.200.73 at 2014-11-01 14:29:42 -0400
Processing by ProjectsController#show as JSON
  Parameters: {"partial"=>"contents_rows", "filters"=>"[[\"uuid\",\"is_a\",\"arvados#collection\"]]", "id"=>"qr1hi-tpzed-tpj2ff66551
eyym"}

...

#<NoMethodError: undefined method `gsub' for nil:NilClass>
/usr/local/lib/ruby/gems/2.1.0/gems/arvados-0.1.20140917180103/lib/arvados/keep.rb:116:in `unescape'
/usr/local/lib/ruby/gems/2.1.0/gems/arvados-0.1.20140917180103/lib/arvados/keep.rb:104:in `block in each_line'
/usr/local/lib/ruby/gems/2.1.0/gems/arvados-0.1.20140917180103/lib/arvados/keep.rb:102:in `each_line'
/usr/local/lib/ruby/gems/2.1.0/gems/arvados-0.1.20140917180103/lib/arvados/keep.rb:102:in `each_line'
/usr/local/lib/ruby/gems/2.1.0/gems/arvados-0.1.20140917180103/lib/arvados/keep.rb:137:in `files'
/home/tom/src/arvados/apps/workbench/app/models/collection.rb:42:in `total_bytes'
/home/tom/src/arvados/apps/workbench/app/models/collection.rb:38:in `content_summary'
/home/tom/src/arvados/apps/workbench/app/views/application/_show_object_description_cell.html.erb:1:in `_app_views_application__show_object_description_cell_html_erb___1631925922960951774_69892807124400'

Subtasks 1 (0 open — 1 closed)