Bug #4388

[SDKs] Manifest#each_line should not crash when encountering a blank line in a manifest.

Added by Tom Clegg over 7 years ago. Updated over 7 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Brett Smith
Category:
SDKs
Target version:
Start date:
11/17/2014
Due date:
% Done:

100%

Estimated time:
(Total: 0.50 h)
Story points:
0.5

Description

While displaying the collections tab on "show Home project":

Started GET "/projects/qr1hi-tpzed-tpj2ff66551eyym?partial=contents_rows&filters=%5B%5B%22uuid%22%2C%22is_a%22%2C%22arvados%23collec
tion%22%5D%5D" for 192.168.200.73 at 2014-11-01 14:29:42 -0400
Processing by ProjectsController#show as JSON
  Parameters: {"partial"=>"contents_rows", "filters"=>"[[\"uuid\",\"is_a\",\"arvados#collection\"]]", "id"=>"qr1hi-tpzed-tpj2ff66551
eyym"}

...

#<NoMethodError: undefined method `gsub' for nil:NilClass>
/usr/local/lib/ruby/gems/2.1.0/gems/arvados-0.1.20140917180103/lib/arvados/keep.rb:116:in `unescape'
/usr/local/lib/ruby/gems/2.1.0/gems/arvados-0.1.20140917180103/lib/arvados/keep.rb:104:in `block in each_line'
/usr/local/lib/ruby/gems/2.1.0/gems/arvados-0.1.20140917180103/lib/arvados/keep.rb:102:in `each_line'
/usr/local/lib/ruby/gems/2.1.0/gems/arvados-0.1.20140917180103/lib/arvados/keep.rb:102:in `each_line'
/usr/local/lib/ruby/gems/2.1.0/gems/arvados-0.1.20140917180103/lib/arvados/keep.rb:137:in `files'
/home/tom/src/arvados/apps/workbench/app/models/collection.rb:42:in `total_bytes'
/home/tom/src/arvados/apps/workbench/app/models/collection.rb:38:in `content_summary'
/home/tom/src/arvados/apps/workbench/app/views/application/_show_object_description_cell.html.erb:1:in `_app_views_application__show_object_description_cell_html_erb___1631925922960951774_69892807124400'

Subtasks

Task #4541: Review 4388-workbench-updateResolvedTom Clegg

Associated revisions

Revision ae96829c (diff)
Added by Brett Smith over 7 years ago

4388: Ruby Keep::Manifest skips blank lines in manifests.

Closes #4388.

Revision 6de0a4ab (diff)
Added by Tom Clegg over 7 years ago

Relax activesupport dependency to accommodate 4.x. refs #4388

Revision d9f45bd0
Added by Tom Clegg over 7 years ago

Merge branch '4388-workbench-update' closes #4388

History

#1 Updated by Tom Clegg over 7 years ago

  • Description updated (diff)
  • Category set to SDKs

#2 Updated by Brett Smith over 7 years ago

  • Status changed from New to In Progress
  • Assigned To set to Brett Smith
  • Target version changed from Bug Triage to 2014-11-19 sprint

#3 Updated by Brett Smith over 7 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100

Applied in changeset arvados|commit:ae96829cc088d18c7aaf438eacb75830c7a40662.

#4 Updated by Tom Clegg over 7 years ago

  • Status changed from Resolved to In Progress

#5 Updated by Brett Smith over 7 years ago

4c110b5f looks great. Thank you for following through on that; sorry for my oversight.

#6 Updated by Anonymous over 7 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100

Applied in changeset arvados|commit:d9f45bd01d2f5691a9aaca4f1fc00465497ef00c.

Also available in: Atom PDF