Project

General

Profile

Actions

Feature #4467

closed

[Workbench] Add "select all" button to project content panes

Added by Bryan Cosca over 9 years ago. Updated almost 9 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Radhika Chippada
Category:
Workbench
Target version:
Story points:
0.5

Description

("If we can do it inside of a data collection, can we do it inside of a project?")


Subtasks 1 (0 open1 closed)

Task #5916: Review branch: 4467-project-contents-select-allResolvedRadhika Chippada05/06/2015Actions
Actions #1

Updated by Bryan Cosca over 9 years ago

for example, what if we want to merge x collections within a project. If regex search functionality also worked, that would be great.

Actions #2

Updated by Tom Clegg over 9 years ago

  • Subject changed from Select all data collections within a project to [Workbench] Add "select all" button to project content panes
  • Description updated (diff)
  • Category set to Workbench
  • Target version set to Arvados Future Sprints
Actions #3

Updated by Tom Clegg about 9 years ago

  • Target version changed from Arvados Future Sprints to 2015-05-20 sprint
Actions #4

Updated by Tom Clegg almost 9 years ago

  • Story points set to 0.5
Actions #5

Updated by Radhika Chippada almost 9 years ago

  • Assigned To set to Radhika Chippada
Actions #6

Updated by Radhika Chippada almost 9 years ago

  • Status changed from New to In Progress
Actions #7

Updated by Peter Amstutz almost 9 years ago

The onclick methods are named select_all_files() and unselect_all_files(), however they are not selecting files. Please rename.

Could we make the select_all and unselect_all methods generic, move them into assets/javascript, and use the same method for both the collections and projects page? For example:

function select_all_items(selector) {
  $(selector).find(":checkbox").filter(":visible").prop("checked", true).trigger("change");
}
<button id="select-all" type="button" class="btn btn-default" onClick="select_all_files('.arv-project-contents')">Select all</button>
Actions #8

Updated by Radhika Chippada almost 9 years ago

Peter: yes, moving into js and reusing this code is a good idea. Updated accordingly. Thanks.

Actions #9

Updated by Peter Amstutz almost 9 years ago

58997b4 LGTM

Actions #10

Updated by Radhika Chippada almost 9 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100

Applied in changeset arvados|commit:dc0237c289882a058a0d5c91b720a4b37917bc9d.

Actions

Also available in: Atom PDF