Project

General

Profile

Actions

Bug #4487

closed

[Workbench] Users shouldn't have the option to "Remove selected" when they don't have the proper permissions

Added by Bryan Cosca over 9 years ago. Updated about 9 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Radhika Chippada
Category:
Workbench
Target version:
Story points:
0.5

Description


Files


Subtasks 1 (0 open1 closed)

Task #4695: Review branch: 4487-and-4558ResolvedRadhika Chippada12/01/2014Actions
Actions #1

Updated by Tim Pierce over 9 years ago

  • Subject changed from Users shouldn't have the option to "Remove selected" when they don't have the proper permissions to [Workbench] Users shouldn't have the option to "Remove selected" when they don't have the proper permissions
  • Category set to Workbench
  • Target version set to Bug Triage
Actions #2

Updated by Radhika Chippada over 9 years ago

  • Status changed from New to In Progress
  • Assigned To set to Radhika Chippada
Actions #3

Updated by Radhika Chippada about 9 years ago

  • Target version changed from Bug Triage to 2014-12-10 sprint
Actions #4

Updated by Brett Smith about 9 years ago

  • Target version changed from 2014-12-10 sprint to Bug Triage

Reviewing 95fd4dd

  • In the view, you can just call @object.editable? to check if the user has write permission. That covers all the corner cases and will save you some typing.
  • In the new test, the name has a typo "avaialble."
  • In the test, please go directly to the project page: visit page_with_token("active", "/projects/#{my_project['uuid']"}). In general, being more conscientious about what pages we visit in integration tests will help keep test runtimes proportional what we're testing.
  • The two assert_no_selector lines are redundant. Just checking li is fine; it will find li.disabled if that exists. Given this, it might make sense to have all the tests look for li.

Thanks.

Actions #5

Updated by Brett Smith about 9 years ago

  • Target version changed from Bug Triage to 2014-12-10 sprint
Actions #6

Updated by Radhika Chippada about 9 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100

Applied in changeset arvados|commit:46aee7d3bec5676e054bddc38633b2775f3a0fd6.

Actions #7

Updated by Ward Vandewege about 9 years ago

  • Story points set to 0.5
Actions

Also available in: Atom PDF