Bug #4487

[Workbench] Users shouldn't have the option to "Remove selected" when they don't have the proper permissions

Added by Bryan Cosca about 6 years ago. Updated almost 6 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Radhika Chippada
Category:
Workbench
Target version:
Start date:
12/01/2014
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
0.5

Description


Subtasks

Task #4695: Review branch: 4487-and-4558ResolvedRadhika Chippada

Associated revisions

Revision 46aee7d3
Added by Radhika Chippada almost 6 years ago

closes #4487
closes #4558
Merge branch '4487-and-4558'

History

#1 Updated by Tim Pierce about 6 years ago

  • Subject changed from Users shouldn't have the option to "Remove selected" when they don't have the proper permissions to [Workbench] Users shouldn't have the option to "Remove selected" when they don't have the proper permissions
  • Category set to Workbench
  • Target version set to Bug Triage

#2 Updated by Radhika Chippada almost 6 years ago

  • Status changed from New to In Progress
  • Assigned To set to Radhika Chippada

#3 Updated by Radhika Chippada almost 6 years ago

  • Target version changed from Bug Triage to 2014-12-10 sprint

#4 Updated by Brett Smith almost 6 years ago

  • Target version changed from 2014-12-10 sprint to Bug Triage

Reviewing 95fd4dd

  • In the view, you can just call @object.editable? to check if the user has write permission. That covers all the corner cases and will save you some typing.
  • In the new test, the name has a typo "avaialble."
  • In the test, please go directly to the project page: visit page_with_token("active", "/projects/#{my_project['uuid']"}). In general, being more conscientious about what pages we visit in integration tests will help keep test runtimes proportional what we're testing.
  • The two assert_no_selector lines are redundant. Just checking li is fine; it will find li.disabled if that exists. Given this, it might make sense to have all the tests look for li.

Thanks.

#5 Updated by Brett Smith almost 6 years ago

  • Target version changed from Bug Triage to 2014-12-10 sprint

#6 Updated by Radhika Chippada almost 6 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100

Applied in changeset arvados|commit:46aee7d3bec5676e054bddc38633b2775f3a0fd6.

#7 Updated by Ward Vandewege almost 6 years ago

  • Story points set to 0.5

Also available in: Atom PDF