Bug #4487: [Workbench] Users shouldn't have the option to "Remove selected" when they don't have the proper permissions - Arvados

Actions

Bug #4487

closed

Added by Bryan Cosca about 10 years ago. Updated about 10 years ago.

Status:

Resolved

Priority:

Normal

Assigned To:

Radhika Chippada

Category:

Workbench

Target version:

Story points:

0.5

Description

Files

Bryan Cosca, 11/11/2014 07:48 PM

Subtasks 1 (0 open — 1 closed)

Actions

Subject changed from Users shouldn't have the option to "Remove selected" when they don't have the proper permissions to [Workbench] Users shouldn't have the option to "Remove selected" when they don't have the proper permissions
Category set to Workbench
Target version set to Bug Triage

Actions

Actions

Actions

Reviewing 95fd4dd

In the view, you can just call @object.editable? to check if the user has write permission. That covers all the corner cases and will save you some typing.
In the new test, the name has a typo "avaialble."
In the test, please go directly to the project page: visit page_with_token("active", "/projects/#{my_project['uuid']"}). In general, being more conscientious about what pages we visit in integration tests will help keep test runtimes proportional what we're testing.
The two assert_no_selector lines are redundant. Just checking li is fine; it will find li.disabled if that exists. Given this, it might make sense to have all the tests look for li.

Thanks.

Actions