Bug #4501

[FUSE] arv-mount --by-id should expose the /by_id directory as well as (not instead of) exposing collections in the mount root

Added by Tom Clegg about 6 years ago. Updated almost 6 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Brett Smith
Category:
-
Target version:
Start date:
11/25/2014
Due date:
% Done:

100%

Estimated time:
(Total: 1.00 h)
Story points:
0.5

Subtasks

Task #4675: Review 4501-fuse-by-id-subdirectory-wipResolvedTom Clegg

Associated revisions

Revision 4b0934a2
Added by Brett Smith almost 6 years ago

Merge branch '4501-fuse-by-id-subdirectory-wip'

Closes #4501, #4675.

History

#1 Updated by Tom Clegg about 6 years ago

  • Target version changed from Arvados Future Sprints to 2014-12-10 sprint

#2 Updated by Brett Smith about 6 years ago

  • Assigned To set to Brett Smith

#3 Updated by Brett Smith about 6 years ago

  • Status changed from New to In Progress

#4 Updated by Tom Clegg almost 6 years ago

At c70fc67...

I noticed that by changing assertEqual to self.assertIn('README', ...) in FuseMagicTest→runTest we lose the test that the self.testcollection directory did not exist before we made it magically appear by reading it:

        # now check some stuff
        self.assertIn('README', os.listdir(self.mounttmp)) # <-- here
        self.assertDirContents(self.testcollection, ['thing1.txt'])
        self.assertDirContents(os.path.join('by_id', self.testcollection),
                               ['thing1.txt'])
        mount_ls = os.listdir(self.mounttmp)
        self.assertIn('README', mount_ls)
        self.assertIn(self.testcollection, mount_ls)
        self.assertIn(self.testcollection,
                      os.listdir(os.path.join(self.mounttmp, 'by_id')))

(It seems like the most important part is that it does appear after. OTOH, since we document "this directory will appear empty until..." perhaps that's worth testing too?)

That's the only complaint I could come up with.

#5 Updated by Brett Smith almost 6 years ago

Tom Clegg wrote:

At c70fc67...

I noticed that by changing assertEqual to self.assertIn('README', ...) in FuseMagicTest→runTest we lose the test that the self.testcollection directory did not exist before we made it magically appear by reading it

Added

self.assertFalse(any(arvados.util.keep_locator_pattern.match(fn) or
                     arvados.util.uuid_pattern.match(fn)
                     for fn in mount_ls),
                 "new FUSE MagicDirectory lists Collection")

at b9caaf61.

#6 Updated by Brett Smith almost 6 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100

Applied in changeset arvados|commit:4b0934a2bb95509468fc4b6132177d47cc7988a8.

Also available in: Atom PDF