Project

General

Profile

Actions

Bug #4501

closed

[FUSE] arv-mount --by-id should expose the /by_id directory as well as (not instead of) exposing collections in the mount root

Added by Tom Clegg over 9 years ago. Updated about 9 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Target version:
Story points:
0.5

Subtasks 1 (0 open1 closed)

Task #4675: Review 4501-fuse-by-id-subdirectory-wipResolvedTom Clegg11/25/2014Actions
Actions #1

Updated by Tom Clegg over 9 years ago

  • Target version changed from Arvados Future Sprints to 2014-12-10 sprint
Actions #2

Updated by Brett Smith over 9 years ago

  • Assigned To set to Brett Smith
Actions #3

Updated by Brett Smith over 9 years ago

  • Status changed from New to In Progress
Actions #4

Updated by Tom Clegg over 9 years ago

At c70fc67...

I noticed that by changing assertEqual to self.assertIn('README', ...) in FuseMagicTest→runTest we lose the test that the self.testcollection directory did not exist before we made it magically appear by reading it:

        # now check some stuff
        self.assertIn('README', os.listdir(self.mounttmp)) # <-- here
        self.assertDirContents(self.testcollection, ['thing1.txt'])
        self.assertDirContents(os.path.join('by_id', self.testcollection),
                               ['thing1.txt'])
        mount_ls = os.listdir(self.mounttmp)
        self.assertIn('README', mount_ls)
        self.assertIn(self.testcollection, mount_ls)
        self.assertIn(self.testcollection,
                      os.listdir(os.path.join(self.mounttmp, 'by_id')))

(It seems like the most important part is that it does appear after. OTOH, since we document "this directory will appear empty until..." perhaps that's worth testing too?)

That's the only complaint I could come up with.

Actions #5

Updated by Brett Smith over 9 years ago

Tom Clegg wrote:

At c70fc67...

I noticed that by changing assertEqual to self.assertIn('README', ...) in FuseMagicTest→runTest we lose the test that the self.testcollection directory did not exist before we made it magically appear by reading it

Added

self.assertFalse(any(arvados.util.keep_locator_pattern.match(fn) or
                     arvados.util.uuid_pattern.match(fn)
                     for fn in mount_ls),
                 "new FUSE MagicDirectory lists Collection")

at b9caaf61.

Actions #6

Updated by Brett Smith over 9 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100

Applied in changeset arvados|commit:4b0934a2bb95509468fc4b6132177d47cc7988a8.

Actions

Also available in: Atom PDF