Arvados

At c70fc67...

I noticed that by changing assertEqual to self.assertIn('README', ...) in FuseMagicTest→runTest we lose the test that the self.testcollection directory did not exist before we made it magically appear by reading it:

        # now check some stuff
        self.assertIn('README', os.listdir(self.mounttmp)) # <-- here
        self.assertDirContents(self.testcollection, ['thing1.txt'])
        self.assertDirContents(os.path.join('by_id', self.testcollection),
                               ['thing1.txt'])
        mount_ls = os.listdir(self.mounttmp)
        self.assertIn('README', mount_ls)
        self.assertIn(self.testcollection, mount_ls)
        self.assertIn(self.testcollection,
                      os.listdir(os.path.join(self.mounttmp, 'by_id')))

(It seems like the most important part is that it does appear after. OTOH, since we document "this directory will appear empty until..." perhaps that's worth testing too?)

That's the only complaint I could come up with.

Tom Clegg wrote:

At c70fc67...

I noticed that by changing assertEqual to self.assertIn('README', ...) in FuseMagicTest→runTest we lose the test that the self.testcollection directory did not exist before we made it magically appear by reading it

Added

self.assertFalse(any(arvados.util.keep_locator_pattern.match(fn) or
                     arvados.util.uuid_pattern.match(fn)
                     for fn in mount_ls),
                 "new FUSE MagicDirectory lists Collection")

at b9caaf61.