Bug #4592

[Workbench] Error when a collection with no name is selected as input to a pipeline component.

Added by Radhika Chippada about 6 years ago. Updated about 6 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Radhika Chippada
Category:
-
Target version:
Start date:
11/20/2014
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
0.5


Subtasks

Task #4624: Review branch: 4592-input-selectionResolvedRadhika Chippada

Associated revisions

Revision 855ba975
Added by Radhika Chippada about 6 years ago

closes #4592
Merge branch '4592-input-selection'

History

#1 Updated by Radhika Chippada about 6 years ago

I selected qr1hi-4zz18-gi71q9r5pwb5voh as input to a pipeline instance (qr1hi-d1hrv-chpg85rdt1vvjcg) and I see error when I click on OK in the chooser dialog. It appears that it is failing while setting the selection_name on a collection with no name.

#<NoMethodError: undefined method `+' for nil:NilClass>
/home/radhika/arvados/apps/workbench/app/controllers/pipeline_instances_controller.rb:89:in `block (2 levels) in update'
/home/radhika/arvados/apps/workbench/app/controllers/pipeline_instances_controller.rb:65:in `each'
/home/radhika/arvados/apps/workbench/app/controllers/pipeline_instances_controller.rb:65:in `block in update'
/home/radhika/arvados/apps/workbench/app/controllers/pipeline_instances_controller.rb:63:in `each'
/home/radhika/arvados/apps/workbench/app/controllers/pipeline_instances_controller.rb:63:in `update'
/home/radhika/arvados/apps/workbench/vendor/bundle/ruby/2.1.0/gems/actionpack-4.1.1/lib/action_controller/metal/implicit_render.rb:4:in `send_action'
/home/radhika/arvados/apps/workbench/vendor/bundle/ruby/2.1.0/gems/actionpack-4.1.1/lib/abstract_controller/base.rb:189:in `process_action'

#3 Updated by Tom Clegg about 6 years ago

  • Story points set to 0.5

#4 Updated by Tom Clegg about 6 years ago

  • Target version changed from Bug Triage to 2014-12-10 sprint

#5 Updated by Radhika Chippada about 6 years ago

  • Assigned To set to Radhika Chippada

#6 Updated by Radhika Chippada about 6 years ago

  • Subject changed from [Workbench] Error when a collection is selected as input to a pipeline component. to [Workbench] Error when a collection with no name is selected as input to a pipeline component.

#7 Updated by Radhika Chippada about 6 years ago

  • Status changed from New to In Progress

#8 Updated by Brett Smith about 6 years ago

Reviewing b4453b1

Everything in the branch looks good. Unfortunately, the new fixture confuses an API server test:

[ 53/297] Arvados::V1::CollectionsControllerTest#test_search_collections_with_'any'_operator = 0.03 s
  1) Failure:
Arvados::V1::CollectionsControllerTest#test_search_collections_with_'any'_operator [/home/brett/repos/arvados/services/api/test/functional/arvados/v1/collections_controller_test.rb:354]:
<2> expected but was
<3>.

This test should probably be modified so it's less brittle when new collections are added.

#9 Updated by Radhika Chippada about 6 years ago

Brett: thanks for noticing this. I added a new collection fixture to be used exclusively by this test. All API and workbench tests passed.

#10 Updated by Brett Smith about 6 years ago

Radhika Chippada wrote:

Brett: thanks for noticing this. I added a new collection fixture to be used exclusively by this test. All API and workbench tests passed.

I like the strategy in c5fd3fb6, but I'm a little concerned the portable data hash of the fixture doesn't accurately reflect the checksum of the manifest. My personal experience has been that having fixtures that reflect real data as closely as possible helps make sure the tests check how things will work in production.

If you're OK changing the portable data hash to match the checksum (5bd9c1ad0bc8c7f34be170a7b7b39089), along with the search term to match, I think this is good to merge. Thanks.

#11 Updated by Radhika Chippada about 6 years ago

Updated the fixture with the correct checksum.

#12 Updated by Radhika Chippada about 6 years ago

  • Status changed from In Progress to Resolved

Applied in changeset arvados|commit:855ba975a64411ec8ed36ddb1a52a46f0b03cb10.

Also available in: Atom PDF