Project

General

Profile

Actions

Bug #4644

closed

[Workbench] When searching a collection with .png's, the png's stay there if you search for any other file

Added by Bryan Cosca over 9 years ago. Updated about 9 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Radhika Chippada
Category:
Workbench
Target version:
Story points:
0.5

Description

For example:

!png bug.png!

I expected only .pdf's to show up


Files

png bug.png (55.2 KB) png bug.png Bryan Cosca, 11/21/2014 04:33 PM

Subtasks 1 (0 open1 closed)

Task #4689: Review branch: 4644-collection-file-filteringResolvedRadhika Chippada12/01/2014Actions
Actions #1

Updated by Tim Pierce over 9 years ago

  • Subject changed from When searching a collection with .png's, the png's stay there if you search for any other file to [Workbench] When searching a collection with .png's, the png's stay there if you search for any other file
  • Category set to Workbench
  • Target version set to Bug Triage
Actions #3

Updated by Radhika Chippada over 9 years ago

  • Status changed from New to In Progress
  • Assigned To set to Radhika Chippada
  • Target version changed from Bug Triage to 2014-12-10 sprint
Actions #4

Updated by Radhika Chippada over 9 years ago

  • The div end tag placement was corrected for an image.
  • Noticed another issue while testing. If there are any directories in the collection, the search filtering was not filtering them out. Added filterable to the directory rows to address this.
Actions #5

Updated by Brett Smith about 9 years ago

Reviewing efc3cdc

Radhika Chippada wrote:

  • The div end tag placement was corrected for an image.

This looks good, thanks.

  • Noticed another issue while testing. If there are any directories in the collection, the search filtering was not filtering them out. Added filterable to the directory rows to address this.

This was an intentional decision during development, to help make sure the user understood where the files were. For an example, look at the test fixture collection zzzzz-4zz18-pyw8yp9g3pr7irn. If you filter this for file, then all the directories will disappear and you'll just get a long list of identical-looking filenames, making it tough to tell which are which. We have real collections that look like this, with the same filenames in a series of directories.

Plus, this apparently breaks the styling; the directory icon no longer appears alongside directory entries.

If you want to push just the closing div fix, that'd be fine by me. Thanks.

Actions #6

Updated by Radhika Chippada about 9 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100

Applied in changeset arvados|commit:d4fa74e36661d22e998dd5a59c21e384284769c7.

Actions #7

Updated by Ward Vandewege about 9 years ago

  • Story points set to 0.5
Actions

Also available in: Atom PDF