Bug #4770: [Workbench] after file upload, the files tab should refresh immediately (overriding the 15 second throttle) - Arvados

Custom queries

All assigned issues
All issues assigned for grooming
My issues for grooming
My issues for grooming (no story pts)
Prioritized open issues

Actions

Copy link

Bug #4770

closed

[Workbench] after file upload, the files tab should refresh immediately (overriding the 15 second throttle)

Added by Ward Vandewege over 9 years ago. Updated over 1 year ago.

Status:

Closed

Priority:

Normal

Assigned To:

Category:

Workbench

Target version:

Story points:

0.5

History
Notes
Property changes

Actions

Copy link

Updated by Brett Smith over 9 years ago

I haven't quite figured out how it works yet, but new files do appear in the Files tab. It doesn't reload the whole tab; instead it's a little more targeted (Websockets?). But they definitely appear after a few moments, even if you previously loaded the Files tab before uploading.

Actions

Copy link

Updated by Tom Clegg over 9 years ago

Category set to Workbench

My first guess is this is a timing issue:

Hit Files tab. Files tab loads at t=0
Hit Upload tab. Upload tab loads at t=2
Choose a file and upload it. Upload finishes at t=8
Hit Files tab. Files tab was already loaded <15s ago, so refresh is deferred

After this sort of sequence, you have to wait <= 15 seconds before the Files tab gets refreshed.

If your Files tab isn't updated and

you have to wait more than { 15 seconds - time since you saw the Files tab }, or
you never looked at the Files tab at all between loading the page and finishing your upload

...then there's a bug to track down. (Or perhaps this is a #4706 symptom.)

Either way, I think it would be appropriate for the "upload finished" event to override the usual 15-second minimum refresh delay so you don't have to look at mysteriously old content even for a few seconds.

Actions

Copy link

Updated by Tom Clegg over 9 years ago

How it works:

At the end of the upload process, there's a collections.update API call
The update causes a Log
Postgres notifies websocket server threads about the Log
Websocket server sends Log to browser
event_log.js sends event to Files tab because it has .arv-log-event-listener[data-object-uuid={collection-uuid}]
tab_panes.js either reloads the tab, or sets a timer to reload the tab (depending on time since last load)

Actions

Copy link

Updated by Tom Clegg over 9 years ago

Brett pointed out that the bug could have been produced by a race condition:

Initiate tab refresh
Workbench prepares current tab content
Collection gets modified, websocket event arrives. Refresh is underway so the event is ignored.
Tab content arrives via AJAX
Tab "loaded" time is set to now, no update request is pending, tab content stays stale.

We should make sure this sort of sequence is handled correctly.

Actions

Copy link

Updated by Tom Clegg over 9 years ago

Target version changed from Bug Triage to Arvados Future Sprints

Actions

Copy link

Updated by Tom Clegg over 9 years ago

Subject changed from [Workbench] after file upload from workbench, going back to the files tab does not automatically refresh the file list to show the newly uploaded files to [Workbench] after file upload, the files tab should refresh immediately (overriding the 15 second throttle)

Actions

Copy link