Bug #4805

[Workbench] Workbench provenance graph tabs appear empty when graph is very large

Added by Peter Amstutz over 4 years ago. Updated over 4 years ago.

Status:
New
Priority:
Normal
Assigned To:
-
Category:
Workbench
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Story points:
0.5

Description

For example, see qr1hi-4zz18-6vg3yynwl37x6tc provenance and used_by graphs. When you open the tab, you'll probably see empty white space. Zoom out a few times, though, and you'll start to see the graph. However, Workbench defaults to showing an upper left portion of the graph, and that's empty in this case.

Fix to implement:

  • See if it's possible to weight Graphviz's rendering so that something is almost guaranteed to render in the upper left. If so, do that.
  • If not, render the initial view so that the graph fits inside it.

There are more UI improvements we should make to this tab, but that's a separate story.

History

#1 Updated by Peter Amstutz over 4 years ago

qr1hi-4zz18-6vg3yynwl37x6tc is missing provenance and used_by graphs, investigate.

#2 Updated by Peter Amstutz over 4 years ago

  • Category set to Workbench

#3 Updated by Tim Pierce over 4 years ago

  • Description updated (diff)

This behavior is consistent with a collection that has been uploaded but not used in any pipelines. Is it possible that's all that's happened here?

#4 Updated by Brett Smith over 4 years ago

Tim Pierce wrote:

This behavior is consistent with a collection that has been uploaded but not used in any pipelines. Is it possible that's all that's happened here?

Afraid not. This Collection is the output of qr1hi-8i9sb-tdhp7eho5ihg4vz.

#5 Updated by Brett Smith over 4 years ago

The graph generation code in the controller #show method is all wrapped in rescue nil. It seems likely that an exception is being eaten.

This should be more like normal error behavior: we want to log that an exception occurred, and encourage the user to report the bug so we can track it down.

#6 Updated by Brett Smith over 4 years ago

  • Subject changed from [Workbench] Provenance graph missing to [Workbench] Workbench provenance graph tabs appear empty when graph is very large

The graph is being generated fine, it's just so ginormous that the upper left part that you're viewing by default is empty. Zoom out a few times and you'll see the graph.

We need a UI fix for this.

#7 Updated by Brett Smith over 4 years ago

  • Description updated (diff)

#8 Updated by Brett Smith over 4 years ago

  • Description updated (diff)
  • Story points set to 0.5

#9 Updated by Tom Clegg over 4 years ago

  • Target version changed from Bug Triage to 2015-02-18 sprint

#10 Updated by Peter Amstutz over 4 years ago

The "smart scroll" javascript is supposed to adjust the size of the DOM box that renders the SVG, so that you get actual scrollbars to indicate what is going on. This never got a proper workbench unit test and has been broken for a long time.

Another thing to add would be to adjust the default zoom level so that the entire graph is on the page at the outset.

#11 Updated by Tom Clegg over 4 years ago

  • Target version changed from 2015-02-18 sprint to Arvados Future Sprints

Also available in: Atom PDF