https://dev.arvados.org/https://dev.arvados.org/favicon.ico?15576888422015-01-10T20:25:58ZArvadosArvados - Bug #4958: [Workbench] Show an alert message below top nav when running in an unsupported browser.https://dev.arvados.org/issues/4958?journal_id=198972015-01-10T20:25:58ZWard Vandewegeward@curii.com
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/19897/diff?detail_id=18985">diff</a>)</li></ul> Arvados - Bug #4958: [Workbench] Show an alert message below top nav when running in an unsupported browser.https://dev.arvados.org/issues/4958?journal_id=198992015-01-10T23:42:54ZTom Cleggtom@curii.com
<ul></ul><p>Server logs show the "upload" tab has been tested by some rather old browsers:</p>
<table>
<tr>
<td>Browser</td>
<td>Released</td>
<td>EOL</td>
<td>Prognosis</td>
</tr>
<tr>
<td>Safari 5.17</td>
<td>May 9, 2012</td>
<td>2013? 2014?</td>
<td>Safari does not have File API until version 7.1. OSX Lion is compatible with <= 6.1.6 and is no longer supported <a href="http://en.wikipedia.org/wiki/Safari_version_history#Version_compatibility" class="external">according to Wikipedia</a></td>
</tr>
<tr>
<td>Firefox 12.0</td>
<td>April 24, 2012</td>
<td>June 5, 2012</td>
<td>Firefox does not have File API until version 33. Oldest supported release is 31.3.0 ESR <a href="http://en.wikipedia.org/wiki/Firefox_release_history#Current_and_future_releases" class="external">according to Wikipedia</a></td>
</tr>
</table>
<p>We should have the upload tab check the browser version (and test API support directly with something like <code>if(window.File && window.Blob)</code>), and show a warning message if it doesn't pass muster.</p> Arvados - Bug #4958: [Workbench] Show an alert message below top nav when running in an unsupported browser.https://dev.arvados.org/issues/4958?journal_id=203162015-01-21T20:56:27ZTom Cleggtom@curii.com
<ul><li><strong>Subject</strong> changed from <i>[Workbench] File upload doesn't work on OS X (Lion) in Safari and Firefox</i> to <i>[Workbench] Show an alert message below top nav when running in an unsupported browser.</i></li></ul> Arvados - Bug #4958: [Workbench] Show an alert message below top nav when running in an unsupported browser.https://dev.arvados.org/issues/4958?journal_id=203172015-01-21T20:56:30ZTom Cleggtom@curii.com
<ul><li><strong>Target version</strong> changed from <i>Bug Triage</i> to <i>2015-02-18 sprint</i></li></ul> Arvados - Bug #4958: [Workbench] Show an alert message below top nav when running in an unsupported browser.https://dev.arvados.org/issues/4958?journal_id=207292015-01-29T20:06:10ZTom Cleggtom@curii.com
<ul><li><strong>Category</strong> set to <i>Workbench</i></li><li><strong>Assigned To</strong> set to <i>Tom Clegg</i></li></ul> Arvados - Bug #4958: [Workbench] Show an alert message below top nav when running in an unsupported browser.https://dev.arvados.org/issues/4958?journal_id=209632015-02-07T22:13:51ZTom Cleggtom@curii.com
<ul><li><strong>File</strong> <a href="/attachments/474">Screenshot from 2015-02-07 17_11_24.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/474/Screenshot%20from%202015-02-07%2017_11_24.png">Screenshot from 2015-02-07 17_11_24.png</a> added</li></ul> Arvados - Bug #4958: [Workbench] Show an alert message below top nav when running in an unsupported browser.https://dev.arvados.org/issues/4958?journal_id=209642015-02-08T02:32:34ZTom Cleggtom@curii.com
<ul><li><strong>File</strong> <a href="/attachments/475">Screenshot from 2015-02-07 21_31_10.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/475/Screenshot%20from%202015-02-07%2021_31_10.png">Screenshot from 2015-02-07 21_31_10.png</a> added</li></ul> Arvados - Bug #4958: [Workbench] Show an alert message below top nav when running in an unsupported browser.https://dev.arvados.org/issues/4958?journal_id=209742015-02-09T03:31:05ZTom Cleggtom@curii.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li></ul> Arvados - Bug #4958: [Workbench] Show an alert message below top nav when running in an unsupported browser.https://dev.arvados.org/issues/4958?journal_id=210342015-02-10T20:24:00ZRadhika Chippadaradhika@curoverse.com
<ul></ul><p>Review comments:</p>
<ul>
<li>The “browser is missing” alert has right margin but no left margin. I think it does not look pretty due to this unbalanced nature. Can you either remove the right border or add same amount of border on left (preferable)?</li>
</ul>
<ul>
<li>Do we also want to add “WebSocket” to browser_unspported.js? I am aware that we only subscribe to event log messages if this is available and is not a show stopper.</li>
</ul>
<ul>
<li>If I were to ignore the warning message and continue with login, I continue to see the warning on the top of the page. I think this is ok, but just pointing it out.
<ul>
<li>However, I think in this case one minor suggestion. If we could make the message a bit smaller so that it would fit in one line (in most cases), it could be nicer.</li>
</ul></li>
</ul>
<ul>
<li>BTW, in the alert message do you want to change "you're running an old version..." to "you are running..."? I think it looks too casual this way.</li>
</ul>
<ul>
<li>Do you want to rename “browser_unsupported.rb” as “browser_unsupported_test.rb” ? All our other tests append _test and this file name threw me off a few times because I was looking for that suffix among all other opened files.</li>
</ul>
<ul>
<li>Do we want to add tests for Blob and File as well? (If you do this, you might want to rename the existing tests and associated properties to read FileReader instead of File)</li>
</ul> Arvados - Bug #4958: [Workbench] Show an alert message below top nav when running in an unsupported browser.https://dev.arvados.org/issues/4958?journal_id=210362015-02-10T22:30:19ZTom Cleggtom@curii.com
<ul><li><strong>File</strong> <a href="/attachments/481">Screenshot from 2015-02-10 17_10_19.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/481/Screenshot%20from%202015-02-10%2017_10_19.png">Screenshot from 2015-02-10 17_10_19.png</a> added</li></ul><blockquote>
<ul>
<li>The “browser is missing” alert has right margin but no left margin. I think it does not look pretty due to this unbalanced nature. Can you either remove the right border or add same amount of border on left (preferable)?</li>
</ul>
</blockquote>
<p>Eliminated both borders, so it looks more like a stripe than a box. (This also gets rid of the rounded corners, which looked weird next to the top nav.)</p>
<blockquote>
<ul>
<li>Do we also want to add “WebSocket” to browser_unspported.js? I am aware that we only subscribe to event log messages if this is available and is not a show stopper.</li>
</ul>
</blockquote>
<p>Good call. Done.</p>
<blockquote>
<ul>
<li>If I were to ignore the warning message and continue with login, I continue to see the warning on the top of the page. I think this is ok, but just pointing it out.
<ul>
<li>However, I think in this case one minor suggestion. If we could make the message a bit smaller so that it would fit in one line (in most cases), it could be nicer.</li>
</ul></li>
</ul>
</blockquote>
<p>I considered some "hide it after the first page" or "hide it after you click the close button" stuff, but the point of this is to make sure it's impossible to forget (or not know) that you're using Workbench in a way that is known to be broken. I think this goal is incompatible with an "ok, I get it, get that out of my way so I can concentrate" feature.</p>
<p>IOW, <em>improving</em> the experience for people who use Workbench in old browsers is out of scope here. The experience is bad: until/unless we fix that, we should make sure they know <em>why</em> it's bad and how they can fix it.</p>
<blockquote>
<ul>
<li>BTW, in the alert message do you want to change "you're running an old version..." to "you are running..."? I think it looks too casual this way.</li>
</ul>
</blockquote>
<p>Done.</p>
<blockquote>
<ul>
<li>Do you want to rename “browser_unsupported.rb” as “browser_unsupported_test.rb” ? All our other tests append _test and this file name threw me off a few times because I was looking for that suffix among all other opened files.</li>
</ul>
</blockquote>
<p>Done. I thought the _test was redundant since they're all in the test/ directory (similarly I try to name test functions <code class="ruby syntaxhl"><span class="nb">test</span> <span class="s1">'it works'</span> <span class="k">do</span><span class="o">...</span></code> instead of <code class="ruby syntaxhl"><span class="nb">test</span> <span class="s1">'test that it works'</span> <span class="k">do</span><span class="o">...</span></code>). But consistency is good, and making it easier to keep track of files seems worthwhile.</p>
<blockquote>
<ul>
<li>Do we want to add tests for Blob and File as well? (If you do this, you might want to rename the existing tests and associated properties to read FileReader instead of File)</li>
</ul>
</blockquote>
<p>Not really. :) Killing the FileReader function (part of the HTML5 "File API") is just a way to make the whole "is it supported?" condition fail, so we can verify that failing the condition really causes the alert to appear.</p>
<p>I feel like maintaining two identical lists of conditions would test our ability to keep the lists synchronized, but wouldn't give us any more confidence that our list of conditions is correct. I think the only worthwhile way to test that the list of conditions is working is to use specific combinations of supported/unsupported features that are known to exist in specific versions of real browsers. (And I don't think this branch should have to wait for that.)</p>
<p>Now at <a class="changeset" title="4958: Merge branch 'master' into 4958-old-browser-alert" href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/5923d0fa912c73e3725e52c869d72793304ae44a">5923d0f</a></p> Arvados - Bug #4958: [Workbench] Show an alert message below top nav when running in an unsupported browser.https://dev.arvados.org/issues/4958?journal_id=210372015-02-10T22:40:03ZRadhika Chippadaradhika@curoverse.com
<ul></ul><p>LGTM</p> Arvados - Bug #4958: [Workbench] Show an alert message below top nav when running in an unsupported browser.https://dev.arvados.org/issues/4958?journal_id=210382015-02-10T22:55:09ZAnonymous
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Resolved</i></li><li><strong>% Done</strong> changed from <i>67</i> to <i>100</i></li></ul><p>Applied in changeset arvados|commit:6bf9ae122958b25b4a22447f67fb11cf24765d97.</p>