[FUSE] Project directories do not refresh.
Project directories are supposed to refresh every 60 seconds, but do not.
Updated by Brett Smith about 9 years ago
The polling-related changes are fine. The bit to have the directory refresh when .arvados#project is opened seems really underdone, though. Given that we update after just sixty seconds, do we really need another knob? How is the user supposed to discover it? Why does it work for projects but not other kinds of directories? Isn't it going to be kind of rough in the case where the first thing the user does is recursively read the directory, since that will mean it makes two API calls back-to-back, with all the associated overhead? Why are you adding a new feature in what is ostensibly a bugfix branch?
My only comment about the code itself is that
open_hook might be a clearer name for the method than
opening, plus the usual PEP 8 comment about having two blank lines after a class definition (applies to both File, and both ends of UpdateOnOpenFile). Thanks.
Updated by Peter Amstutz about 9 years ago
The idea was something like this
- Program is listening to event bus
- Program gets an event indicating that the project has changed
- Program is going to do some work involving the project directory
- Trigger a refresh by reading ".arvados#project" so the work is using an up-to-date project directory.
A better way to do this would be to get update events directly from the file system -- possibly using