Bug #5016

[SDKs] Should be able to use ^C to interrupt arv-ws.

Added by Peter Amstutz about 5 years ago. Updated about 5 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Target version:
Start date:
01/21/2015
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
0.5

Subtasks

Task #5017: Review 5016-ctrl-c-arv-wsResolvedPeter Amstutz


Related issues

Has duplicate Arvados - Bug #4507: [SDKs] arv ws should exit on ctrl-cDuplicate

Associated revisions

Revision ffcfb73e
Added by Peter Amstutz about 5 years ago

Merge branch '5016-ctrl-c-arv-ws' closes #5016

History

#1 Updated by Peter Amstutz about 5 years ago

  • Assigned To set to Peter Amstutz

#2 Updated by Ward Vandewege about 5 years ago

  • Subject changed from Should be able to use ^C to interrupt arv-ws. to [SDKs] Should be able to use ^C to interrupt arv-ws.

#3 Updated by Brett Smith about 5 years ago

691d642 does the job, but it can be surprisingly sluggish. Here's a transcript where I hit ^C as soon as I saw the fallback notices:

brinstar % arv-ws; date
2015-01-21 10:12:03 arvados.events[21214] WARNING: Got exception _ssl.c:331: No root certificates specified for verification of other-side certificates. trying to connect to websockets at wss://ws.qr1hi.arvadosapi.com/websocket
2015-01-21 10:12:03 arvados.events[21214] WARNING: Websockets not available, falling back to log table polling
^CWed Jan 21 10:12:16 EST 2015

Taking about 10-13 seconds is what I typically saw, independently of how I set the poll interval. If there's a way to make it snappier, that seems like it'd be nice, but if not, this is good to merge. Thanks.

#4 Updated by Brett Smith about 5 years ago

Okay, I see now that what's going on in my last comment is that the thread is blocking on the first large API response of logs, and that ^C reacts more like expected after that. So that leaves me less concerned and I'm happy to see the branch merged as-is.

#5 Updated by Peter Amstutz about 5 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100

Applied in changeset arvados|commit:ffcfb73e6a5dfd626b1d523accc42e7a6af5e8ed.

Also available in: Atom PDF