Bug #5030

[Workbench] Stats graph display for job without stats is confusing

Added by Brett Smith over 5 years ago. Updated over 5 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench
Target version:
Start date:
01/20/2015
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
0.5

Description

See attached screenshot for how a job log tab looks when a job is in the install step but hasn't started actually running. There are guidelines for the graph but no other graph information, so it's not clear that a graph is going to go there. It just looks like wasted space on the page.

log-dividers.png (38.9 KB) log-dividers.png Brett Smith, 01/20/2015 04:43 PM

Subtasks

Task #5168: Hide graph div until data points arriveResolvedTom Clegg

Task #5172: Review 5030-hide-graph-until-dataResolvedTom Clegg

Associated revisions

Revision 1bcfe865
Added by Tom Clegg over 5 years ago

Merge branch '5030-hide-graph-until-data' closes #5030

History

#1 Updated by Brett Smith over 5 years ago

  • Subject changed from [Workbench] Strange empty divider sections on Log tab for running Job to [Workbench] Stats graph display for job without stats is confusing
  • Description updated (diff)

#2 Updated by Tom Clegg over 5 years ago

  • Story points set to 0.5

#3 Updated by Tom Clegg over 5 years ago

  • Target version changed from Bug Triage to 2015-02-18 sprint

#4 Updated by Tom Clegg over 5 years ago

Suggest:
  • Make the graph div hidden by default. display:none or whatever.
  • show() the graph using a cheesy1 animation when the first point gets plotted.

1 Cheese is optional.

#5 Updated by Tom Clegg over 5 years ago

  • Assigned To set to Tom Clegg

#6 Updated by Tom Clegg over 5 years ago

  • Status changed from New to In Progress

#7 Updated by Radhika Chippada over 5 years ago

Review notes:

I focused on the "actual" changes (though the diff is 680 lines long due to moving js code into a new file - much better).

Everything looked good. Also, verified manually testing and seeing the graph display in action.

LGTM.

#8 Updated by Anonymous over 5 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 50 to 100

Applied in changeset arvados|commit:1bcfe8651af341c6e7cd01a19443c7c288efa932.

Also available in: Atom PDF