Arvados

In "This collection was the output of:" maybe change this to "This collection was uploaded by" if its not an output of a job.

5034-workbench-collection-summary-wip is up for review. Some notes about the story implementation.

Tom Clegg wrote:

The "summary" area at the top of the page should include:

• UUID (except in the special case where the page was loaded via PDH instead of UUID)

The special case can't happen because if you look up a collection by PDH, the controller searches for other collections with that PDH and does one of two things: if there's a single result, you get redirected to the collection page by UUID; and if there's more than one, you get a list. See the block in CollectionsControll#show starting if Keep::Locator.parse params["uuid"].

• Optional/nice: copy-to-clipboard feature for PDH and UUID (see #5027)

For security reasons, it's not possible to copy to the clipboard in native JavaScript. I've done the next best thing I know: when you click/focus the text, the entire text is automatically highlighted, so you can just hit Ctrl+C or whatever to make your copy.

This isn't a common UI thing, so I went back and forth on how to present it to the user. I went with a half-inlaid appearance. I'm sure we can bikeshed the presentation to death.

Brett, looks great. Just a few minor suggestions.

• _show_autoselect_text.html
  • The comment says “Render local ‘text’ …” It is a bit confusing. Can you expand this comment to say local variable text … or something?
  • Is the input tag missing the terminating ‘/‘ character?

• _show_source_summary:
  • All other items have titles and values such as “Arvados UUID:”, “Content address:”, “This collection was the output of:” etc. I think it would look more balanced if we have a title such as “Collection metrics:” for the number of files and size info.
  • “Arvados UUID”: Everything is Arvados, right :) ? I think “Collection UUID” might be a better title for this item.
  • Both “Arvados UUID” and “Content address” are using the same tagclass. Is this intentional?

• Selectable uuid and pdh text: Usually an underlined text means a clickable link in webpages. The left border is barely visible as well. I am concerned that the auto-select underlining might confuse users. I suggest making the left border more visible with a touch of blue color, and removing the bottom line. Alternatively, we can put the text in a “box” by having the top and right borders also.

Forgot to say this in my previous comment. The summary information is taking quite some space in the collection#show page now and occupying almost half the space in my browser window (my laptop terminal size). It would be desirable that this does not take too much space.

Are we planning to implement a "summary" tab for collections (I vaguely remember seeing it yesterday but I am not sure if I am imagining things) in which case we can move some of this stuff into that tab when we have it.

If we not have plans to implement a Summary tab for collections, I suggest revisiting the display layout of items in this page for the Summary panel. Some suggestions: we can remove dax image from the summary panel and display items in single row layout (some thing like "UUID: xxxxx-xxxxx-xxxxxxxxxxxxxx", "Address: ..." ). Just display them in a single line and let them wrap as needed, which should save quite some space here and make it take less space.

2¢: I'm inclined to defer as much as possible of the UI-tweaking to #5415.

Radhika Chippada wrote:

Brett, looks great. Just a few minor suggestions.

• The comment says “Render local ‘text’ …” It is a bit confusing. Can you expand this comment to say local variable text … or something?

Done.

• Is the input tag missing the terminating ‘/‘ character?

No, <input> must not have a closing tag, and a trailing / is just shorthand for that.

• All other items have titles and values such as “Arvados UUID:”, “Content address:”, “This collection was the output of:” etc. I think it would look more balanced if we have a title such as “Collection metrics:” for the number of files and size info.

I have added it as "Content size." I feel like "metrics" often gets used in the context of number of visits/downloads/etc. which is information we might want to provide later.

• “Arvados UUID”: Everything is Arvados, right :) ? I think “Collection UUID” might be a better title for this item.

Done.

• Both “Arvados UUID” and “Content address” are using the same tagclass. Is this intentional?

Yes. It's purely presentational (right now it sets some font details), so it's fine to use for both. At different times in the past, we've used it for both collection PDHs and Arvados object UUIDs.

• Selectable uuid and pdh text: Usually an underlined text means a clickable link in webpages. The left border is barely visible as well. I am concerned that the auto-select underlining might confuse users. I suggest making the left border more visible with a touch of blue color, and removing the bottom line. Alternatively, we can put the text in a “box” by having the top and right borders also.

I have put it in a rounded box with a little more padding that turns blue when you select it. This mimics the style GitHub uses for its clone URL widget (you can see it in the right sidebar of, e.g., our repository), which has the same behavior. If you want more changes, please let me know the exact CSS you'd like and I'll add it.

Per Tom, I have left the rest of the UI work you discussed for #5415, which is also on this sprint. Now at ad4c4cf. Thanks.

Brett:

• Ok with #5415 to improve UI

• Can we add glyphicon-copy next to the Collection uuid and content address elements? (I was thinking about it and now see that in github as well. We do not need to make ours selectable though).

LGTM even if you prefer not to add glyphicon-copy :).

Thanks.

Radhika Chippada wrote:

• Can we add glyphicon-copy next to the Collection uuid and content address elements? (I was thinking about it and now see that in github as well. We do not need to make ours selectable though).

LGTM even if you prefer not to add glyphicon-copy :).

I thought about adding some kind of icon, but since we don't have any functionality to hook it up to, I'm afraid people will try to click it and get frustrated when it does nothing. So I'm going to merge as-is, and we'll see what kind of user feedback we get and go from there. Thanks very much.